-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/services refactoring #76
Closed
Closed
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d0e4949
Refavtored Navigation service and adding test coverage
himanshu-wedensday 0b090b2
Refavtored Navigation service and adding test coverage
himanshu-wedensday 0d8dcdd
Refavtored Navigation service and adding test coverage
himanshu-wedensday e99c2d9
fixed root saga tests
himanshu-wedensday e28acda
fixed root saga tests
himanshu-wedensday 92e6ee8
feat: conflict resolve
himanshu-wedensday 28cabca
feat: conflict resolve
himanshu-wedensday 6d47b4e
feat: saga test code refactor
himanshu-wedensday File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { NavigationActions } from '@react-navigation/compat'; | ||
import { navigate, setTopLevelNavigator } from '../NavigationService'; | ||
jest.mock('@react-navigation/compat', () => ({ | ||
NavigationActions: { | ||
navigate: jest.fn() | ||
} | ||
})); | ||
const navigatorRef = { goBack: 'goBack', dispatch: jest.fn() }; | ||
setTopLevelNavigator(navigatorRef); | ||
describe('navigate', () => { | ||
afterEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
|
||
it('dispatches navigation action with the correct routeName and params', () => { | ||
const routeName = '/test'; | ||
const params = { screen: 'MainScreen' }; | ||
NavigationActions.navigate.mockReturnValueOnce({ | ||
type: 'NAVIGATE_ACTION', | ||
payload: { routeName, params } | ||
}); | ||
navigate(routeName, params); | ||
expect(NavigationActions.navigate).toHaveBeenCalledWith({ | ||
routeName, | ||
params | ||
}); | ||
expect(navigatorRef.dispatch).toHaveBeenCalledWith({ | ||
type: 'NAVIGATE_ACTION', | ||
payload: { routeName, params } | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { StackActions } from '@react-navigation/compat'; | ||
import { setTopLevelNavigator, navigateAndReset } from '../NavigationService'; | ||
|
||
jest.mock('@react-navigation/compat', () => ({ | ||
StackActions: { | ||
replace: jest.fn() | ||
} | ||
})); | ||
const navigatorRef = { goBack: 'goBack', dispatch: jest.fn() }; | ||
setTopLevelNavigator(navigatorRef); | ||
describe('test navigateAndReset', () => { | ||
afterEach(() => { | ||
// Reset mocks after each test | ||
jest.clearAllMocks(); | ||
}); | ||
|
||
it('dispatches stack action with the correct routeName and params', () => { | ||
const routeName = '/test'; | ||
const params = { screen: 'MainScreen' }; | ||
StackActions.replace.mockReturnValueOnce({ | ||
type: 'NAVIGATE_ACTION', | ||
payload: { routeName, params } | ||
}); | ||
navigateAndReset(routeName, params); | ||
expect(StackActions.replace).toHaveBeenCalledWith({ | ||
routeName, | ||
params | ||
}); | ||
expect(navigatorRef.dispatch).toHaveBeenCalledWith({ | ||
type: 'NAVIGATE_ACTION', | ||
payload: { routeName, params } | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import set from 'lodash/set'; | ||
import { setTopLevelNavigator } from '../NavigationService'; | ||
jest.mock('lodash/set', () => jest.fn()); | ||
describe('setTopLevelNavigator', () => { | ||
afterEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
it('sets the navigator object with the provided reference', () => { | ||
const navigatorObject = { | ||
navigator: null | ||
}; | ||
const navigatorRef = { goBack: 'goBack' }; | ||
setTopLevelNavigator(navigatorRef); | ||
expect(set).toHaveBeenCalledWith( | ||
navigatorObject, | ||
'navigator', | ||
navigatorRef | ||
); | ||
}); | ||
}); |
2 changes: 1 addition & 1 deletion
2
app/services/UserService.test.js → app/services/tests/userService.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use aliases while importing.
So, "@services/NavigationService"