Refactored root screen #77
Conversation
WalkthroughThis update involves a refactor of the RootScreen component to a functional setup using hooks, enhancing the navigation handling in the startup saga. Additionally, the rootContainerReducer now utilizes lodash for more dynamic action type management. The testing framework has been updated to align with these changes, ensuring continued reliability and performance. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 262ae8f |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
app/scenes/RootScreen/reducer.js
Outdated
| const stateReturn = { | ||
| [rootScreenTypes.STARTUP]: state | ||
| }; | ||
| return get(stateReturn, [action.type], state); |
There was a problem hiding this comment.
Refactor the reducer to directly return the new state from the get function, which can simplify the code and improve readability. Here's a suggested change:
- const stateReturn = {
- [rootScreenTypes.STARTUP]: state
- };
- return get(stateReturn, [action.type], state);
+ return get({ [rootScreenTypes.STARTUP]: state }, action.type, state);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const stateReturn = { | |
| [rootScreenTypes.STARTUP]: state | |
| }; | |
| return get(stateReturn, [action.type], state); | |
| return get({ [rootScreenTypes.STARTUP]: state }, action.type, state); |
app/scenes/RootScreen/reducer.js
Outdated
| default: | ||
| return state; | ||
| } | ||
| const stateReturn = { |
There was a problem hiding this comment.
this introduces more complexity than the switch. Let's continue using the switch please
Ticket Link
Related Links
Description
Steps to Reproduce / Test
GIF's
Summary by CodeRabbit
Refactor
Bug Fixes
Tests