Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ios workflow #94

Closed
wants to merge 14 commits into from
Closed

Feat/ios workflow #94

wants to merge 14 commits into from

Conversation

himanshu-wedensday
Copy link
Contributor

@himanshu-wedensday himanshu-wedensday commented Apr 23, 2024

Ticket Link


Related Links


Description


Steps to Reproduce / Test


GIF's


Summary by CodeRabbit

  • New Features

    • Introduced automated iOS build process through GitHub Actions.
    • Enhanced app configuration to support multiple build environments.
    • Updated project dependencies for improved functionality.
  • Documentation

    • Updated project metadata and configuration settings in app.json.
    • Added eas.json file for build environment configuration.

Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The project has embraced new tools and configurations for iOS builds through GitHub Actions, Expo, and EAS. These changes encompass the introduction of a new workflow, adjustments to the app's identification and owner details, and the incorporation of essential dependencies to facilitate building and distributing the iOS application across various environments.

Changes

File Path Change Summary
.github/workflows/ios-build.yml Set up "IOS Build" workflow for iOS builds triggered by manual dispatch and branch pushes.
app.json Modified slug, added extra with eas config, and owner field in expo configuration.
eas.json Introduced settings for build environments and distribution preferences for different stages.
package.json Included eas-cli and expo-cli dependencies with specific versions.

🐇💻✨
O hark! A new build flows,
Through wires and codes it goes.
From push to branch, it grows,
In digital fields, our project shows.
🌟📱🚀


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 82f9de4 and 0a7e865.
Files selected for processing (1)
  • .github/workflows/ios-build.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ios-build.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 95.12% 195/205
🟢 Branches 87.18% 34/39
🟢 Functions 93.51% 72/77
🟢 Lines 95.58% 173/181

Test suite run success

54 tests passing in 24 suites.

Report generated by 🧪jest coverage report action from 0a7e865

This comment has been minimized.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (1)
eas.json (1)

10-10: Consider specifying explicit configurations for the production environment to avoid relying on defaults, which might not be optimal.

Comment on lines +18 to +21
uses: expo/expo-github-action@v8
with:
eas-version: latest
token: 1KN9lFRor6yda_6Q0vSxwClEBfrdq8xhYo7klaQ5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing sensitive tokens in the workflow file poses a security risk. Consider using GitHub Secrets to manage sensitive information securely.

Copy link

sonarqube-ws bot commented Apr 23, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (94.10% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: wednesday-solutions_react-native-template_AY7hdnRSB2n8RRmGoU2M

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant