-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ios workflow #94
Conversation
…-native-template into feat/ios-workflow
WalkthroughThe project has embraced new tools and configurations for iOS builds through GitHub Actions, Expo, and EAS. These changes encompass the introduction of a new workflow, adjustments to the app's identification and owner details, and the incorporation of essential dependencies to facilitate building and distributing the iOS application across various environments. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Test suite run success54 tests passing in 24 suites. Report generated by 🧪jest coverage report action from 0a7e865 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
eas.json (1)
10-10
: Consider specifying explicit configurations for the production environment to avoid relying on defaults, which might not be optimal.
uses: expo/expo-github-action@v8 | ||
with: | ||
eas-version: latest | ||
token: 1KN9lFRor6yda_6Q0vSxwClEBfrdq8xhYo7klaQ5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing sensitive tokens in the workflow file poses a security risk. Consider using GitHub Secrets to manage sensitive information securely.
Ticket Link
Related Links
Description
Steps to Reproduce / Test
GIF's
Summary by CodeRabbit
New Features
Documentation
app.json
.eas.json
file for build environment configuration.