Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fixes, dotenv and growthbook #95

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Eslint fixes, dotenv and growthbook #95

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87467a5
fix: fix complexity in eslint
rohankeskarwednesday Aug 21, 2024
c9bd7c9
fix: fix complexity
rohankeskarwednesday Aug 21, 2024
2855013
feat: add env support
rohankeskarwednesday Aug 21, 2024
e451c07
feat: add sentry
rohankeskarwednesday Aug 26, 2024
ec00ffb
feat: sentry integration
rohankeskarwednesday Aug 26, 2024
8c11040
pr comments
Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
JSON_PLACEHOLDER_API="https://jsonplaceholder.typicode.com"
SIMPSONS_API="https://thesimpsonsquoteapi.glitch.me/"
15 changes: 7 additions & 8 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
const fs = require('fs');
const path = require('path');


const prettierOptions = JSON.parse(
fs.readFileSync(path.resolve(__dirname, '.prettierrc'), 'utf8'),
fs.readFileSync(path.resolve(__dirname, '.prettierrc'), 'utf8')
);
module.exports = {
root: true,
parser: 'babel-eslint',
extends: [
'airbnb',
'prettier',
'prettier',
'prettier/react',
'plugin:prettier/recommended',
'plugin:sonarjs/recommended',
Expand Down Expand Up @@ -54,13 +53,13 @@ module.exports = {
'import/no-unresolved': 0,
'import/prefer-default-export': 0,
'react/jsx-props-no-spreading': 0,
'camelcase': ['error', { 'properties': 'always', ignoreImports: false}],
camelcase: ['error', { properties: 'always', ignoreImports: false }],
indent: [
2,
2,
{
SwitchCase: 1,
},
SwitchCase: 1
}
],
'jsx-a11y/aria-props': 2,
'jsx-a11y/heading-has-content': 0,
Expand Down Expand Up @@ -120,7 +119,7 @@ module.exports = {
}
],
'no-shadow': 'error',
complexity: ['error', 10],
complexity: ['error', 2],
'no-empty': 'error',
'import/order': [
'error',
Expand Down Expand Up @@ -171,4 +170,4 @@ module.exports = {
}
}
}
};
};
4 changes: 3 additions & 1 deletion app/config/index.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { JSON_PLACEHOLDER_API } from '@env';

export const Config = {
API_URL: 'https://jsonplaceholder.typicode.com/users/'
API_URL: `${JSON_PLACEHOLDER_API}/users/`
};
4 changes: 3 additions & 1 deletion app/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { SIMPSONS_API } from '@env';

export const Config = {
API_URL: 'https://thesimpsonsquoteapi.glitch.me/'
API_URL: SIMPSONS_API
};
4 changes: 3 additions & 1 deletion app/config/index.production.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { JSON_PLACEHOLDER_API } from '@env';

export const Config = {
API_URL: 'https://jsonplaceholder.typicode.com/users/'
API_URL: `${JSON_PLACEHOLDER_API}/users/`
};
64 changes: 64 additions & 0 deletions app/utils/growthbook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import { GrowthBook } from '@growthbook/growthbook';
import { GROWTH_BOOK_API_HOST, GROWTH_BOOK_CLIENT_KEY } from '@env';

let growthBookClient;

/**
* creates an instance of the growthBook client
* @returns growthBook client
*/
export const createGrowthBookClient = userEmail => {
const growthBook = new GrowthBook({
apiHost: GROWTH_BOOK_API_HOST,
clientKey: GROWTH_BOOK_CLIENT_KEY,
enableDevMode: true,
subscribeToChanges: true
});

growthBook.setAttributes({
email: userEmail
});

return growthBook;
};

/**
* Function to get the GrowthBook client instance
* @returns {GrowthBook} growthBook instance
*/
export function getGrowthBookClient(email) {
if (growthBookClient) {
return growthBookClient;
}
return createGrowthBookClient(email);
}

/**
* Function to get growthBook feature
* @param {String} email
* @returns {Applicant} growthBook feature value
*/
export async function getGrowthBookFeaturesData(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.getFeatureValue(name);
} catch (error) {
return new Error(error);
}
Comment on lines +41 to +48
Copy link

@coderabbitai coderabbitai bot Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve error handling in getGrowthBookFeaturesData.

Instead of returning an Error object, consider throwing the error to maintain consistency in error handling practices.

Apply this diff to improve error handling:

-    return new Error(error);
+    throw error;
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export async function getGrowthBookFeaturesData(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.getFeatureValue(name);
} catch (error) {
return new Error(error);
}
export async function getGrowthBookFeaturesData(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.getFeatureValue(name);
} catch (error) {
throw error;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check this once

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamoilattaar-wednesday, I've reviewed the suggestion to throw the error instead of returning a new Error object in the getGrowthBookFeaturesData function. This change aligns with standard error handling practices in JavaScript, allowing errors to propagate up the call stack for proper handling. It looks like a valid improvement. Let me know if you need further assistance!

}

/**
* Function to get growthBook feature
* @param {String} name
* @returns {Boolean} growthBook feature status
*/
export async function getGrowthBookFeatureFlag(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.isOn(name);
} catch (error) {
return new Error(error);
}
Comment on lines +56 to +63
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve error handling in getGrowthBookFeatureFlag.

Instead of returning an Error object, consider throwing the error to maintain consistency in error handling practices.

Apply this diff to improve error handling:

-    return new Error(error);
+    throw error;
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export async function getGrowthBookFeatureFlag(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.isOn(name);
} catch (error) {
return new Error(error);
}
export async function getGrowthBookFeatureFlag(name, email) {
try {
const growthBook = getGrowthBookClient(email);
await growthBook.loadFeatures();
return growthBook.isOn(name);
} catch (error) {
throw error;
}

}
11 changes: 11 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ module.exports = function(api = { cache: () => {} }) {
'@utils': './app/utils'
}
}
],
[
'module:react-native-dotenv',
{
moduleName: '@env',
path: '.env',
blacklist: null,
whitelist: null,
safe: false,
allowUndefined: true
}
]
]
};
Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,7 @@ SPEC CHECKSUMS:
RNReanimated: 8a4d86eb951a4a99d8e86266dc71d7735c0c30a9
RNScreens: b6b64d956af3715adbfe84808694ae82d3fec74f
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Yoga: 805bf71192903b20fc14babe48080582fee65a80
Yoga: d17d2cc8105eed528474683b42e2ea310e1daf61

PODFILE CHECKSUM: 71a7eba1109c7de188217c03cf1824ab1d487aec

Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"dependencies": {
"@babel/polyfill": "7.12.1",
"@expo/webpack-config": "~19.0.1",
"@growthbook/growthbook": "^1.2.0",
"@react-native-async-storage/async-storage": "1.23.1",
"@react-native-community/masked-view": "^0.1.11",
"@react-native/metro-config": "^0.75.0-main",
Expand Down Expand Up @@ -137,6 +138,7 @@
"prettier-eslint": "^9.0.0",
"prettier-standard": "^15.0.1",
"pretty-quick": "^1.11.1",
"react-native-dotenv": "^3.4.11",
"react-native-rename": "^3.2.14",
"react-test-renderer": "^18.2.0"
},
Expand Down
21 changes: 20 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,13 @@
resolved "https://registry.yarnpkg.com/@graphql-typed-document-node/core/-/core-3.2.0.tgz#5f3d96ec6b2354ad6d8a28bf216a1d97b5426861"
integrity sha512-mB9oAsNCm9aM3/SOv4YtBMqZbYj10R7dkq8byBqxGY/ncFwhf2oQzMV+LCRlWoDSEBJ3COiR1yeDvMtsoOsuFQ==

"@growthbook/growthbook@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@growthbook/growthbook/-/growthbook-1.2.0.tgz#e0859f14614a50cd9cadb603b0834b2203be829c"
integrity sha512-lL47UKvzUaUq2QLwiePrUbM/p+NPv6WUGrGs2bjw1Zc51dtNtxAD+s1hXEU9wpAF913kbiOW2+yRa67UhxSkuw==
dependencies:
dom-mutator "^0.6.0"

"@hapi/hoek@^9.0.0", "@hapi/hoek@^9.3.0":
version "9.3.0"
resolved "https://registry.yarnpkg.com/@hapi/hoek/-/hoek-9.3.0.tgz#8368869dcb735be2e7f5cb7647de78e167a251fb"
Expand Down Expand Up @@ -5855,6 +5862,11 @@ dom-converter@^0.2.0:
dependencies:
utila "~0.4"

dom-mutator@^0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/dom-mutator/-/dom-mutator-0.6.0.tgz#079d7a4b3e8981a562cd777548b99baab51d65c5"
integrity sha512-iCt9o0aYfXMUkz/43ZOAUFQYotjGB+GNbYJiJdz4TgXkyToXbbRy5S6FbTp72lRBtfpUMwEc1KmpFEU4CZeoNg==

dom-serializer@^1.0.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/dom-serializer/-/dom-serializer-1.4.1.tgz#de5d41b1aea290215dc45a6dae8adcf1d32e2d30"
Expand Down Expand Up @@ -5930,7 +5942,7 @@ dotenv-expand@~11.0.6:
dependencies:
dotenv "^16.4.4"

dotenv@^16.3.1, dotenv@^16.4.4, dotenv@~16.4.5:
dotenv@^16.3.1, dotenv@^16.4.4, dotenv@^16.4.5, dotenv@~16.4.5:
version "16.4.5"
resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-16.4.5.tgz#cdd3b3b604cb327e286b4762e13502f717cb099f"
integrity sha512-ZmdL2rui+eB2YwhsWzjInR8LldtZHGDoQ1ugH85ppHKwpUHL7j7rN0Ti9NCnGiQbhaZ11FpR+7ao1dNsmduNUg==
Expand Down Expand Up @@ -11449,6 +11461,13 @@ react-native-cli@^2.0.1:
prompt "^0.2.14"
semver "^5.0.3"

react-native-dotenv@^3.4.11:
version "3.4.11"
resolved "https://registry.yarnpkg.com/react-native-dotenv/-/react-native-dotenv-3.4.11.tgz#2e6c4eabd55d5f1bf109b3dd9141dadf9c55cdd4"
integrity sha512-6vnIE+WHABSeHCaYP6l3O1BOEhWxKH6nHAdV7n/wKn/sciZ64zPPp2NUdEUf1m7g4uuzlLbjgr+6uDt89q2DOg==
dependencies:
dotenv "^16.4.5"

react-native-gesture-handler@~2.16.0:
version "2.16.0"
resolved "https://registry.yarnpkg.com/react-native-gesture-handler/-/react-native-gesture-handler-2.16.0.tgz#45a00b5988e74ebc58f130c8d1443319c8e678db"
Expand Down
Loading