server: throw exception if fail to cleanup IP resources when release …

…a public IP
weizhouapache · May 8, 2024 · 4f0b26b · 4f0b26b
1 parent ea9a0f4
commit 4f0b26b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
@@ -732,8 +732,9 @@ public boolean disassociatePublicIpAddress(long addrId, long userId, Account cal
         PublicIpQuarantine publicIpQuarantine = null;
         // Cleanup all ip address resources - PF/LB/Static nat rules
         if (!cleanupIpResources(addrId, userId, caller)) {
-            success = false;
-            s_logger.warn("Failed to release resources for ip address id=" + addrId);
+            String msg = String.format("Failed to release resources for ip address id=%s", addrId);
+            s_logger.error(msg);
+            throw new CloudRuntimeException(msg);
         }
 
         IPAddressVO ip = markIpAsUnavailable(addrId);