Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm configuration for WEKA #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bskjerven
Copy link

Added Python script to read and modify Slurm configuration for RealMemory and CpuSpecList
Moved WEKA scripts to util directory to match AWS repo format
Modified lifecycle_script to use Slurm configuration script
Added enable_weka option to config script

Added Python script to read and modify Slurm configuration for RealMemory and CpuSpecList
Moved WEKA scripts to util directory to match AWS repo format
Modified lifecycle_script to use Slurm configuration script
Added enable_weka option to config script
@assafgi
Copy link
Contributor

assafgi commented Nov 29, 2024

@bskjerven, since the files here are copied from AWS official files, I wanted to separate the files we edited.
If you check the example.sh you will see that I do:

cp set_weka.sh lifecycle_script.py base-config

The reason I did it this way is that I believe our users already have their lifescycle scripts and I wanted them to have a clear picture of the unique parts we have and that they should integrate.
I am not sure the current structure I used in the repo is optimal, but at least it should be very simple to explain any user about the required updates on his side.
If you have other suggestion, we can discuss it.

@bskjerven
Copy link
Author

Thanks @assafgi. I missed you did the copy. As long as we document how to do it and it have some standardization, I don't mind which way we do it.
The other main reason I put the weka slurm script in utils is to be able to import it as a python module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants