-
-
Notifications
You must be signed in to change notification settings - Fork 31
add pip support #27
base: master
Are you sure you want to change the base?
add pip support #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's always sane to just upgrade python packages. There's no way to hold back any upgrades if for some reason you rely on a specific version of a package.
@@ -0,0 +1,5 @@ | |||
#!/usr/bin/env bash | |||
echo "🐍 Python pip" | |||
pip freeze --local | grep -v '^\-e' | cut -d = -f 1 | xargs pip install -U |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this won't work if you happen to run kymsu
inside a virtualenv
. Maybe add some check to see if a virtualenv is active? Something like if [[ -z $VIRTUAL_ENV && -z $PYENV_VERSION ]]; then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to call pip install -U --upgrade-strategy eager
so dependencies also get updated.
@@ -0,0 +1,5 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a check to see if pip
is available, it's not available by default on OS X.
@@ -0,0 +1,5 @@ | |||
#!/usr/bin/env bash | |||
echo "🐍 Python pip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pip freeze
doesn't list pip
itself it's necessary to first call pip install -U pip
to self update.
This PR is open for a long time without news, should I close it? |
to update globally installed python stuff