Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct support for embedded CBOR-in-CBOR #286

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcoutts
Copy link
Member

@dcoutts dcoutts commented Mar 23, 2022

This is the tag 24 stuff.

This should just be an optimisation. The semantic change is already
available as encodePreEncoded :: B.ByteString -> Encoding

This branch was done some time ago. It looks fine as far as it goes.

TODOs it will need:

  • to be rebased,
  • have the API version numbers in the haddock comments updated, and
  • most importantly tests and benchmarks adding. The tests should show that it's equivalent to the normal alternative. The benchmarks should show that it's faster than the normal alternative.

This is the tag 24 stuff.

This should just be an optimisation. The semantic change is already
available as encodePreEncoded :: B.ByteString -> Encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant