Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverstripe 5 compatibility #35

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Silverstripe 5 compatibility #35

merged 4 commits into from
Apr 29, 2024

Conversation

aletail
Copy link
Member

@aletail aletail commented Apr 24, 2024

Summary

Updates for silverstripe 5 compatibility

Testing Steps

  • Test with base install and silverstripe 5 recipe
  • Test dev/task index task
  • Test the site search

Issues/Concerns

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"

Empty content is checked for before adding/updating an index. If it is empty the index is not added/updated
@aletail aletail requested a review from tiller1010 April 24, 2024 19:07
composer.json Outdated
"php": "^8.1",
"silverstripe/cms": "^5",
"silverstripe/framework": "^5",
"teamtnt/tntsearch": "v4.2.1",
"ext-sqlite3": "*",
"symbiote/silverstripe-queuedjobs": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a ^5.1 constraint for this?

@aletail aletail requested a review from tiller1010 April 26, 2024 17:55
Copy link
Member

@tiller1010 tiller1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aletail aletail merged commit a9aefad into develop Apr 29, 2024
1 check failed
@aletail aletail deleted the feature/ss-5-update branch April 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants