Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative includes #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix relative includes #19

wants to merge 1 commit into from

Conversation

manisandro
Copy link

The installed libzrtpcpp headers (placed in /usr/include/libzrtpcpp) usually include themselves via

#include <libzrtpcpp/XXX>

and projects using libzrtpcpp do so as well (i.e. sflphone). There are however a few cases where headers in /usr/include/libzrtpcpp include other headers using the angle-bracket #include but without the libzrtpcpp/, i.e.

#include <ZrtpQueue.h>
#include <CcrtpTimeoutProvider.h>
#include <common/osSpecifics.h>

This breaks compilation of i.e. sflphone, since the headers cannot be found. This pull request changes those include statements to using the #include with quotes:

#include "ZrtpQueue.h"
/* etc */

Using #include <libzrtpcpp/XXX> in those cases does not work since in the source files the headers are not placed beneath the libzrtpcpp folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant