Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buzblox.com, gonetor.com, mailifyy.com and related domains #457

Merged
merged 4 commits into from
May 7, 2024

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Apr 24, 2024

@Igloczek Igloczek changed the title Add buzblox.com and related domains Add buzblox.com, gonetor.com and related domains Apr 25, 2024
@Igloczek Igloczek changed the title Add buzblox.com, gonetor.com and related domains Add buzblox.com, gonetor.com, mailifyy.com and related domains May 3, 2024
@emh-rowland-oconnor emh-rowland-oconnor merged commit 25eee96 into wesbos:master May 7, 2024
2 checks passed
@emh-rowland-oconnor
Copy link
Collaborator

thank you.

@nullpainter
Copy link

This has added my personal deity.co.nz domain which is now causing havoc with my email. This is not, nor has ever been a burner domain.

#459

@wesbos
Copy link
Owner

wesbos commented May 9, 2024

@Igloczek Where did you get this list? Seems like many on here are not real email domains

@tompec
Copy link
Contributor

tompec commented May 9, 2024

The PR should be reverted. More domains from the PR are not disposable and have been added simply because they have forwardemail.net MX records (e.g., calvarylufkin.org).
These domains appear to have been incorrectly flagged by verifymail.io, the source used by @Igloczek.

Large lists of thousands or even hundreds of domains should not be added all at once, as it is impossible for maintainers to verify each one.

@nullpainter
Copy link

nullpainter commented May 9, 2024

Ah - that would be why my domain was on there. I use the free tier of https://forwardemail.net/ so use forwardemail.net MX records.

@titanism
Copy link

titanism commented May 9, 2024

Can you please revert this PR?

@nullpainter
Copy link

The PR should be reverted. More domains from the PR are not disposable and have been added simply because they have forwardemail.net MX records (e.g., calvarylufkin.org). These domains appear to have been incorrectly flagged by verifymail.io, the source used by @Igloczek.

Large lists of thousands or even hundreds of domains should not be added all at once, as it is impossible for maintainers to verify each one.

FWIW, I have emailed verifymail.io to alert them of their misclassification.

@Igloczek
Copy link
Contributor Author

Igloczek commented May 9, 2024

@wesbos "root" domains: buzblox.com, gonetor.com, mailifyy.com are coming from my manual review, they are related to some fraudulent activities in my apps like creating tons of accounts to abuse free tier, or using fake credit cards for payments.

All the "related" domains are from verifymail.io, as @tompec said.

But I disagree with the opinion about adding lots of domains at once, since you would almost always either have an incomplete list, so the price of occasional false positives doesn't seem to be very high.

@Igloczek
Copy link
Contributor Author

Igloczek commented May 9, 2024

I've created a PR that removes all domains related to forwardemail.net - #461

@Igloczek Igloczek deleted the patch-2 branch May 9, 2024 05:26
@nullpainter
Copy link

nullpainter commented May 9, 2024

But I disagree with the opinion about adding lots of domains at once, since you would almost always either have an incomplete list, so the price of occasional false positives doesn't seem to be very high.

Speaking as somebody who has lost emails because of this PR and then had to pay for a premium service to bypass use of the lists maintained by this repository - at 4am, because I couldn't sleep, worrying - I strongly disagree.

I've been chill about this because this was an honest mistake, but please don't downplay the human impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants