Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for different utils (string, map, regex) #20

Merged
merged 3 commits into from
Dec 5, 2019
Merged

tests for different utils (string, map, regex) #20

merged 3 commits into from
Dec 5, 2019

Conversation

ulitol97
Copy link
Member

@ulitol97 ulitol97 commented Dec 5, 2019

This PR implementes new test cases to enhance the repo codecov as part of #4
Three commits are included:

75ada2a , new tests for string utils and avoid out of bounds exception (when the string had only one character the functions kept looking for the next character)
d40de22 , new tests for MapUtils to cover more of MapUtils functionality

291a0b6 , new tests for regex to cover more of RegexUtils functionality

The IDE added some "false" insertions/deletions 🙄

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #20 into master will increase coverage by 4.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   35.82%   39.87%   +4.04%     
==========================================
  Files          23       23              
  Lines         494      494              
  Branches       39       42       +3     
==========================================
+ Hits          177      197      +20     
+ Misses        317      297      -20
Impacted Files Coverage Δ
.../utils/src/main/scala/es/weso/utils/StrUtils.scala 91.35% <83.33%> (+22.22%) ⬆️
...tils/src/main/scala/es/weso/utils/RegexUtils.scala 100% <0%> (+16.66%) ⬆️
.../utils/src/main/scala/es/weso/utils/MapUtils.scala 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991ea26...291a0b6. Read the comment docs.

@thewillyhuman
Copy link
Member

Awesome, thanks!

@thewillyhuman thewillyhuman merged commit ae0f513 into weso:master Dec 5, 2019
@ulitol97 ulitol97 deleted the codecov-utils branch December 13, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants