This repository has been archived by the owner on May 25, 2021. It is now read-only.
Method for calculating a value for N depending on CPU speed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi HungryHobo I love the idea but I've a few questions / remarks. See below. Regards Cerber |
| @@ -23,6 +25,12 @@ | |||
| public class SCrypt { | |||
There was a problem hiding this comment.
Why do you place this method inside the main class ?
Since it's use case is not part of "standard operations" why don't you extract it to another class ?
There was a problem hiding this comment.
You're absolutely right, it belongs in ScryptUtil. I accidentally put it in Scrypt.java.
I'll push a fix. Thanks for pointing this out.
|
I have updated the pull request based on GrmpCerber's feedback. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to merge this if you think it adds value.