DataclassToProto: Remove unnecessary @DataClass layering

Since @dataobject takes care of making the wrapped class a dataclass, we don't need that extra line. Also grep turned up some dead code Signed-off-by: Gabe Goodhart <[email protected]>
wgifford · May 2, 2023 · 7e331d4 · 7e331d4
1 parent d9e9648
commit 7e331d4
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 11 deletions.
diff --git a/caikit/core/data_model/producer.py b/caikit/core/data_model/producer.py
@@ -14,8 +14,6 @@
 """
 Common data model objects used to identify the producer of a given output
 """
-# Standard
-from dataclasses import dataclass
 
 # Local
 from .dataobject import CAIKIT_DATA_MODEL, dataobject
@@ -24,7 +22,6 @@
 
 
 @dataobject(PACKAGE_COMMON)
-@dataclass
 class ProducerId:
     """Information about a data structure and the module that produced it."""
 

diff --git a/caikit/interfaces/common/data_model/producer.py b/caikit/interfaces/common/data_model/producer.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 # Standard
-from dataclasses import dataclass
 from typing import List
 
 # First Party
@@ -28,7 +27,6 @@
 
 
 @dataobject(PACKAGE_COMMON)
-@dataclass
 class ProducerPriority:
     """An ordered list of ProducerId structures in descending order of priority.
     This is used when handling conflicts between multiple producers of the same

diff --git a/caikit/runtime/model_management/training_manager.py b/caikit/runtime/model_management/training_manager.py
@@ -9,12 +9,6 @@
 from caikit.interfaces.runtime.data_model import TrainingStatus
 from caikit.runtime.types.caikit_runtime_exception import CaikitRuntimeException
 
-#
-# @dataclasses.dataclass
-# class TrainingStuff:
-#     status: TrainingStatus
-#     exception: Exception
-
 
 class TrainingManager:
     __instance: "TrainingManager" = None