-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-label usage in BMP coverage table #261
Comments
cc @hsivonen |
My reading of the relevant best-practice guidance and relevant spec requirements lead me to believe a warning for that is appropriate, and so the As far as the spec requirements go, https://w3c.github.io/html-aam/#other-tabular-data-elements says that for “tr, td, th Elements Accessible Name Computation”, the step that implementations must start with is:
Notice it says “the table element”. So I take that to mean that implementations must essentially ignore whatever Does my reading of that seem correct? If my reading of that is in fact correct, then as far as the checker behavior goes, doesn’t that mean it’s appropriate for the checker to warn about not using As far as the related best-practice guidance, the source I have been following for that is https://html5accessibility.com/stuff/2020/11/07/not-so-short-note-on-aria-label-usage-big-table-edition/, which explicitly recommends not using |
Upon further reflection, I realize this could well be a copypasta spec bug in the AAM spec — so I raised w3c/html-aam#335 over there to get clarification. |
Update: @scottaohara has updated the relevant language in the AAM spec to make it more clear. So I think it now unambiguously states the relevant implementation requirements. (Thanks Scott!) However, at w3c/html-aam#335 (comment), Scott points out:
Therefore, I think having the checker not emit a warning for a @scottaohara, can you suggest any alternative ARIA markup for the https://encoding.spec.whatwg.org/windows-1252.html table, or is it in fact the case that those table cells shouldn’t have any ARIA markup at all? And to be clear, replacing |
Perhaps someone else from @whatwg/a11y can advise on this? |
noting also that
would mean (if SRs actually used the I'd say in general, rather than trying to patch things with
|
or use
Note: the implementation is flaky currently |
Thanks for the quick responses and guidance! Given that these tables are purely informal, I'll go with Steve's suggestion for now. If we get an actual report about this being problematic for someone we'll have to re-evaluate. |
if it's known to still be flaky, why go with that approach rather than the more robust (admittedly slightly more verbose) visually hidden text? |
Because we haven't had anyone complain about |
@sideshowbarker #260 fails to build because https://encoding.spec.whatwg.org/windows-1253-bmp.html has
aria-label
usage that the HTML checker warns for.Basically, it's a lot of stuff like:
The text was updated successfully, but these errors were encountered: