Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use "set up" for TransformStreams rather than "create" #260

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

andreubotella
Copy link
Member

@andreubotella andreubotella commented May 28, 2021

Follows whatwg/streams#1110.

I just noticed that the Encoding standard was failing to build because of these changes to the Streams standards.


Preview | Diff

@andreubotella
Copy link
Member Author

andreubotella commented May 28, 2021

The build failures are caused by the visualization and BMP coverage tables (https://encoding.spec.whatwg.org/windows-1252.html for example), since they have aria-label attributes on <td> elements, which as of validator/validator@02332d5 causes the HTML checker to fail.

@sideshowbarker Changing the aria-label attributes to title would make the checker work, but I'm not sure whether that'd be fine accessibility-wise.

cc @annevk

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@annevk
Copy link
Member

annevk commented May 31, 2021

Thanks! I suggest we sort #261 first. I also think that we should land this prefixed with "Editorial:" as it ends up changing the prose, not just the references.

@sideshowbarker
Copy link
Contributor

sideshowbarker commented May 31, 2021

@sideshowbarker Changing the aria-label attributes to title would make the checker work, but I'm not sure whether that'd be fine accessibility-wise.

Per a strict reading of the current wording of the implementation requirements at https://w3c.github.io/html-aam/#other-tabular-data-elements, I believe it would not be wrong accessibility-wise to change the aria-label attributes to title. However, it seems like that current wording in the AAM spec may not actually makes much sense and may instead be a spec bug. I mean, why would it make sense to use any title attribute on the td/th/tr, but not make use of any aria-lable attribute?

So I raised w3c/html-aam#335 to get clarification.

If a change does end up getting made to the AAM spec, then I guess it would be appropriate for me to change the checker back to allowing aria-label on td/th/tr without warning. I say “I guess” because https://html5accessibility.com/stuff/2020/11/07/not-so-short-note-on-aria-label-usage-big-table-edition/ says that td/th/tr for “aria-label use not well supported” in UAs/AT. So I take that to mean those aria-label attributes would in practice not actually get exposed as accessible names in practice in current UAs/AT. And I suspect that title wouldn’t either. So I really don’t know what’s best to do here…

@andreubotella andreubotella changed the title Meta: Use "set up" for TransformStreams rather than "create" Editorial: Use "set up" for TransformStreams rather than "create" May 31, 2021
@annevk annevk merged commit 9c640be into main Jun 21, 2021
@annevk annevk deleted the andreubotella/stream-setup branch June 21, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants