Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CORS-preflight fetches set the CORS flag #743

Merged
merged 1 commit into from
May 29, 2018
Merged

Make CORS-preflight fetches set the CORS flag #743

merged 1 commit into from
May 29, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented May 28, 2018 •
edited by pr-preview bot
Loading

Otherwise a 401 response would not necessarily result in rejection.

Fixes #741.

Preview | Diff

@annevk
Make CORS-preflight fetches set the CORS flag
eefc882 
Otherwise a 401 response would not necessarily result in rejection.

Fixes #741.
@annevk annevk requested a review from youennf May 28, 2018 12:40
@annevk annevk mentioned this pull request May 29, 2018
Merged
youennf
youennf approved these changes May 29, 2018
View reviewed changes
Copy link
Collaborator

@youennf youennf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annevk annevk merged commit 9334fcb into master May 29, 2018
@annevk annevk deleted the annevk/cors-preflight-cors-flag branch May 29, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @youennf