Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: make Form submission section unique #5675

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Editorial: make Form submission section unique #5675

merged 1 commit into from
Jun 25, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Jun 25, 2020 •
edited by pr-preview bot
Loading

Also give it both its old and logical ID. Helps with #5672.

/form-control-infrastructure.html ( diff )
/index.html ( diff )

@annevk
Editorial: make Form submission section unique
0678e4c 
Also give it both its old and logical ID. Helps with #5672.
sideshowbarker
sideshowbarker approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@annevk annevk merged commit 4fd7b88 into master Jun 25, 2020
@annevk annevk deleted the annevk/form-submission-ids branch June 25, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @sideshowbarker @domenic