Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add width and height attributes to source elements #5894

Merged
merged 38 commits into from
Feb 25, 2021
Merged

Add width and height attributes to source elements #5894

merged 38 commits into from
Feb 25, 2021

Commits on Feb 15, 2021

  1. Add width and height attributes to source elements

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    925b789 View commit details
    Browse the repository at this point in the history

  2. Change to use an internal slot instead of setting attributes

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5672203 View commit details
    Browse the repository at this point in the history

  3. Review comments

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    c342720 View commit details
    Browse the repository at this point in the history

  4. Add conditional on picture to authoring requirements

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    64119b0 View commit details
    Browse the repository at this point in the history

  5. simplify aspect ratio source algorithm + nits

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    3c13507 View commit details
    Browse the repository at this point in the history

  6. Added comment about intrinsic dimensions

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    92c4e87 View commit details
    Browse the repository at this point in the history

  7. Review comments about naming being aspect ratio specific

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    0ee7b9a View commit details
    Browse the repository at this point in the history

  8. s/intrinsic dimensions/maps to the dimension properties/

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    67371dc View commit details
    Browse the repository at this point in the history

  9. Remove reference to dimension properties from note

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5d604ae View commit details
    Browse the repository at this point in the history

  10. Split out the image requirements from other elements

    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    e8526b2 View commit details
    Browse the repository at this point in the history

  11. Ensure that width and height from source only apply when present, and… 

    … add them to relevant mutations
    @yoavweiss
    yoavweiss committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    2fbe374 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. set dimension source to el itself in case there are no dimension attr… 

    …ibutes
    @yoavweiss
    yoavweiss committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b1084c5 View commit details
    Browse the repository at this point in the history

  2. Review comments from Domenic

    @yoavweiss
    yoavweiss committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    bcfeced View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Bring back IDL and reflect on it

    @yoavweiss
    yoavweiss committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    bbee14c View commit details
    Browse the repository at this point in the history

  2. Update the attribute index

    @yoavweiss
    yoavweiss committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    73b6e7c View commit details
    Browse the repository at this point in the history

  3. Remove redundant reflection since the ohter section does it

    @domenic
    domenic committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    61e8bad View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Add width and height attributes to source elements

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    1eec7db View commit details
    Browse the repository at this point in the history

  2. Change to use an internal slot instead of setting attributes

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    b80dc2e View commit details
    Browse the repository at this point in the history

  3. Review comments

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    ca509ea View commit details
    Browse the repository at this point in the history

  4. Add conditional on picture to authoring requirements

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    4c6696d View commit details
    Browse the repository at this point in the history

  5. simplify aspect ratio source algorithm + nits

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    29916b4 View commit details
    Browse the repository at this point in the history

  6. Added comment about intrinsic dimensions

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    8d194d3 View commit details
    Browse the repository at this point in the history

  7. Review comments about naming being aspect ratio specific

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    d720e33 View commit details
    Browse the repository at this point in the history

  8. s/intrinsic dimensions/maps to the dimension properties/

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    7cb5ab1 View commit details
    Browse the repository at this point in the history

  9. Remove reference to dimension properties from note

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6b88939 View commit details
    Browse the repository at this point in the history

  10. Split out the image requirements from other elements

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9a4ad57 View commit details
    Browse the repository at this point in the history

  11. Ensure that width and height from source only apply when present, and… 

    … add them to relevant mutations
    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    615ae3b View commit details
    Browse the repository at this point in the history

  12. set dimension source to el itself in case there are no dimension attr… 

    …ibutes
    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    d8c6ca7 View commit details
    Browse the repository at this point in the history

  13. Review comments from Domenic

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    eea5bc6 View commit details
    Browse the repository at this point in the history

  14. Bring back IDL and reflect on it

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    a2f052b View commit details
    Browse the repository at this point in the history

  15. Update the attribute index

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6bc8b14 View commit details
    Browse the repository at this point in the history

  16. Oxford comma

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    1f560a7 View commit details
    Browse the repository at this point in the history

  17. Change reference to intrinsic aspect ratio

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    af586d8 View commit details
    Browse the repository at this point in the history

  18. map to the aspect ratio property

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    79d65bb View commit details
    Browse the repository at this point in the history

  19. merge

    @yoavweiss
    yoavweiss committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9da7f7e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Revert dom-dim-* explicit reflection prose

    @yoavweiss
    yoavweiss committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7fbd75f View commit details
    Browse the repository at this point in the history

  2. Style the revert

    @yoavweiss
    yoavweiss committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e9112e4 View commit details
    Browse the repository at this point in the history

  3. Clarify what is "the element"

    @yoavweiss
    yoavweiss committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    79535c6 View commit details
    Browse the repository at this point in the history