Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setTimeout() when there's no active script #9712

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 9, 2023

Closes #9633.

(See WHATWG Working Mode: Changes for more details.)


/timers-and-user-prompts.html ( diff )

@domenic
Copy link
Member Author

domenic commented Sep 10, 2023

@bathos and/or @Lubrsi, if you have time to check this out, please take a look!

@bathos
Copy link

bathos commented Sep 10, 2023

Looks right to me!

@hiroshige-g
Copy link
Contributor

Looks good.

The current Chromium's behavior is actually "always no active script", so as for "no active script" case, no fix is needed.

https://bugs.chromium.org/p/chromium/issues/detail?id=1133238 listed is actually about fixing "with active script" case.

@Lubrsi
Copy link

Lubrsi commented Sep 12, 2023

LGTM! Fixes SerenityOS/serenity#20970, implementation can be found here: SerenityOS/serenity#21051

Lubrsi added a commit to Lubrsi/serenity that referenced this pull request Sep 12, 2023
Lubrsi added a commit to Lubrsi/serenity that referenced this pull request Sep 12, 2023
Lubrsi added a commit to Lubrsi/serenity that referenced this pull request Sep 14, 2023
Lubrsi added a commit to Lubrsi/serenity that referenced this pull request Sep 14, 2023
awesomekling pushed a commit to SerenityOS/serenity that referenced this pull request Sep 15, 2023
juniorrantila pushed a commit to juniorrantila/serenity that referenced this pull request Sep 16, 2023
@domenic domenic merged commit 8d997ba into main Sep 24, 2023
1 check passed
@domenic domenic deleted the fix-settimeout branch September 24, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Are the “active script” & “base URL” assertions in the timer initialization steps correct?
5 participants