-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setTimeout() when there's no active script #9712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks right to me! |
Looks good. The current Chromium's behavior is actually "always no active script", so as for "no active script" case, no fix is needed. https://bugs.chromium.org/p/chromium/issues/detail?id=1133238 listed is actually about fixing "with active script" case. |
LGTM! Fixes SerenityOS/serenity#20970, implementation can be found here: SerenityOS/serenity#21051 |
Lubrsi
added a commit
to Lubrsi/serenity
that referenced
this pull request
Sep 12, 2023
Lubrsi
added a commit
to Lubrsi/serenity
that referenced
this pull request
Sep 12, 2023
Lubrsi
added a commit
to Lubrsi/serenity
that referenced
this pull request
Sep 14, 2023
Lubrsi
added a commit
to Lubrsi/serenity
that referenced
this pull request
Sep 14, 2023
awesomekling
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Sep 15, 2023
juniorrantila
pushed a commit
to juniorrantila/serenity
that referenced
this pull request
Sep 16, 2023
annevk
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9633.
(See WHATWG Working Mode: Changes for more details.)
/timers-and-user-prompts.html ( diff )