Editorial: modernize the language around actions #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to give them more associated concepts.
|
I went ahead with this as it's editorial. Happy to address any nits of course, as always. |
saschanaz
reviewed
Jul 10, 2024
| the main body of the notification to open their inbox. | ||
| <p>Here a service worker shows a notification with a single "Archive" <a for=/>action</a>, allowing | ||
| users to perform this common task from the notification without having to open the website (for | ||
| example the, notification platform might show a button on the notification). The user can also |
There was a problem hiding this comment.
Suggested change
| example the, notification platform might show a button on the notification). The user can also | |
| example, the notification platform might show a button on the notification). The user can also |
There was a problem hiding this comment.
Oh wow, how did that happen. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to give them more associated concepts.
Preview | Diff