Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
annevk committed Jun 4, 2018
1 parent bd35e7e commit 2be718c
Showing 1 changed file with 19 additions and 20 deletions.
39 changes: 19 additions & 20 deletions url.bs
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ U+0020 SPACE, U+0023 (#), U+0025 (%), U+002F (/), U+003A (:), U+003F (?), U+0040
U+005C (\), or U+005D (]).

<p>A <a for=/>host</a>'s <dfn for=host export>public suffix</dfn> is the portion of a
<a for=/>host</a> which is included on the Public Suffix List [[!PSL]]. To obtain
<var>host</var>'s <a for=host>public suffix</a>, run these steps:
<a for=/>host</a> which is included on the <cite>Public Suffix List</cite>. To obtain
<var>host</var>'s <a for=host>public suffix</a>, run these steps: [[!PSL]]

<ol>
<li><p>If <var>host</var> is not a <a>domain</a>, then return null.
Expand All @@ -285,17 +285,16 @@ U+005C (\), or U+005D (]).
</ol>

<p>A <a for=/>host</a>'s <dfn for=host export>registrable domain</dfn> is a <a>domain</a> formed by
the most specific public suffix, along with the domain label immediately preceeding it. If no such
label is available, the <a for=host>registrable domain</a> is null. To obtain <var>host</var>'s
<a for=host>registrable domain</a>, run these steps:
the most specific public suffix, along with the domain label immediately preceeding it, if any. To
obtain <var>host</var>'s <a for=host>registrable domain</a>, run these steps:

<ol>
<li><p>If <var>host</var>'s <a for=host>public suffix</a> is null or <var>host</var>'s
<a for=host>public suffix</a> <a for=host>equals</a> <var>host</var>, then return null.

<li><p>Return the <a for=host>registrable domain</a> obtained by executing the
<a href="https://publicsuffix.org/list/">algorithm</a> defined by the Public Suffix List on
<var>host</var>. [[!PSL]].
<var>host</var>. [[!PSL]]
</ol>

<div class=example id=example-host-psl>
Expand Down Expand Up @@ -351,45 +350,45 @@ label is available, the <a for=host>registrable domain</a> is null. To obtain <v
<dfn for=host export>same site</dfn> with each other if either of the following statements are true:

<ul class=brief>
<li><p><var>A</var> <a for=host>equals</a> <var>B</var>, and <var>A</var>'s <a for=host>registrable
domain</a> is not null.
<li><p><var>A</var> <a for=host>equals</a> <var>B</var> and <var>A</var>'s
<a for=host>registrable domain</a> is non-null.

<li><p><var>A</var>'s <a for=host>registrable domain</a> is <var>B</var>'s
<a for=host>registrable domain</a> and is not null.
<a for=host>registrable domain</a> and is non-null.
</ul>

<div class=example id=example-same-site>
<p>Assuming that <code>suffix.example</code> is a <a for=host>public suffix</a>, and that
<p>Assuming that <code>suffix.example</code> is a <a for=host>public suffix</a> and that
<code>example.com</code> is not:

<ul>
<li><p><code>example.com</code>, <code>sub.example.com</code>, <code>other.example.com</code>,
<code>sub.sub.example.com</code>, and <code>sub.other.example.com</code> are all <a>same site</a>
with each other (and themselves), as each host's <a for=host>registrable domain</a> is
with each other (and themselves), as each their <a for=host>registrable domain</a> is

This comment has been minimized.

Copy link
@mikewest

mikewest Jun 4, 2018

Member

s/each their/each of their/. That also makes things plural, so "domains".

<code>example.com</code>.

<li><p><code>registrable.suffix.example</code>, <code>sub.registrable.suffix.example</code>,
<code>other.registrable.suffix.example</code>, <code>sub.sub.registrable.suffix.example</code>,
and <code>sub.other.registrable.suffix.example</code> are all <a>same site</a> with each other
(and themselves), as each host's <a for=host>registrable domain</a> is
(and themselves), as each their <a for=host>registrable domain</a> is

This comment has been minimized.

Copy link
@mikewest

mikewest Jun 4, 2018

Member

Ditto.

<code>registrable.suffix.example</code>.

<li><p><code>example.com</code> and <code>registrable.suffix.example</code> are not <a>same
site</a> with each other, as their <a for=host>registrable domains</a> differ.
<li><p><code>example.com</code> and <code>registrable.suffix.example</code> are not
<a>same site</a> with each other, as their <a for=host>registrable domains</a> differ.

<li><p><code>suffix.example</code> is not <a>same site</a> with <code>suffix.example</code>, as
it is a <a for=host>public suffix</a>, and therefore has a null <a for=host>registrable
domain</a>.
it is a <a for=host>public suffix</a>, and therefore has a null
<a for=host>registrable domain</a>.

This comment has been minimized.

Copy link
@mikewest

mikewest Jun 4, 2018

Member

I thought it was alright to break inside a link? I need to skim the style guide, obviously...

This comment has been minimized.

Copy link
@annevk

annevk Jun 4, 2018

Author Member

Just HTML. Maybe I should align all the things with HTML, but I kinda like not having to regexp search for terms.

This comment has been minimized.

Copy link
@mikewest

mikewest Jun 4, 2018

Member

👍

</ul>
</div>

<p class=warning>Specifications should avoid relying on "<a for=host>public suffix</a>",
<p class=warning>Specifications should avoid depending on "<a for=host>public suffix</a>",
"<a for=host>registrable domain</a>", and "<a>same site</a>". The public suffix list will diverge
from client to client, and cannot be relied-upon to provide a hard security boundary. Specifications
which ignore this advice are encouraged to carefully consider whether URLs' schemes ought to be
incorporated into any decision made based upon whether or not two <a for=/>hosts</a> are <a>same
site</a>. HTML's <a>same origin-domain</a> concept is a reasonable example of this consideration in
practice.
incorporated into any decision made based upon whether or not two <a for=/>hosts</a> are
<a>same site</a>. HTML's <a>same origin-domain</a> concept is a reasonable example of this
consideration in practice.


<h3 id=idna>IDNA</h3>
Expand Down

1 comment on commit 2be718c

@mikewest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.