Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDNA hostnames end up using emdash instead of -- for ACE-encoded labels #471

Closed
sleevi opened this issue Mar 26, 2020 · 2 comments · Fixed by #472
Closed

IDNA hostnames end up using emdash instead of -- for ACE-encoded labels #471

sleevi opened this issue Mar 26, 2020 · 2 comments · Fixed by #472

Comments

@sleevi
Copy link

sleevi commented Mar 26, 2020

https://url.spec.whatwg.org/commit-snapshots/0ce82da2b6734cdfa55652954ecc9dee9ed9b951/#example-host-psl

The public suffix renders as xn-kgbechtv when it should be xn--kgbechtv
@annevk
Copy link
Member

annevk commented Mar 27, 2020 •
edited
Loading

This happened in #391 and nobody noticed at the time. (It also seems to be a hyphen.)

annevk added a commit that referenced this issue Mar 27, 2020
@annevk
Correct and add to PSL examples
b55c921 
The ASCII prefix is xn--, not xn-. Also add an example where the public suffix is null as callers used to forget about it.

Closes #471.
@annevk annevk mentioned this issue Mar 27, 2020
Merged
@annevk
Copy link
Member

annevk commented Mar 27, 2020

See #472.

annevk added a commit that referenced this issue Mar 27, 2020
@annevk
Correct and add to PSL examples
7fbd29c 
The ASCII prefix is xn--, not xn-. Also add an example where the public suffix is null as callers used to forget about it.

Closes #471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct and add to PSL examples whatwg/url
2 participants
@sleevi @annevk