Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and add to PSL examples #472

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Correct and add to PSL examples #472

merged 2 commits into from
Mar 27, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 27, 2020

The ASCII prefix is xn--, not xn-. Also add an example where the public suffix is null as callers used to forget about it.

Closes #471.


Preview | Diff

The ASCII prefix is xn--, not xn-. Also add an example where the public suffix is null as callers used to forget about it.

Closes #471.
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Punycode is hard. Thanks for the fix!

@annevk annevk merged commit 7fbd29c into master Mar 27, 2020
@annevk annevk deleted the annevk/registrable-domain branch March 27, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

IDNA hostnames end up using emdash instead of -- for ACE-encoded labels
2 participants