Fix Dialyzer warnings

whatyouhide · Aug 17, 2023 · 96303f0 · 96303f0
1 parent e7c9143
commit 96303f0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -75,13 +75,11 @@ jobs:
 
   test:
     name: >-
-      Test (
-      Elixir ${{ matrix.elixir }},
+      Test (Elixir ${{ matrix.elixir }},
       OTP ${{ matrix.otp }},
       C* ${{ matrix.server_versions.cassandra }},
       Scylla ${{ matrix.server_versions.scylla }},
-      Native protocol ${{ matrix.cassandra_native_protocol }}
-      )
+      Native protocol ${{ matrix.cassandra_native_protocol }})
 
     runs-on: ubuntu-20.04
 

diff --git a/lib/xandra/cluster/control_connection.ex b/lib/xandra/cluster/control_connection.ex
@@ -223,7 +223,10 @@ defmodule Xandra.Cluster.ControlConnection do
         else
           {:error, {:use_this_protocol_instead, _failed_protocol_version, proto_vsn}} ->
             state = update_in(state.transport, &Transport.close/1)
-            state = put_in(state.connection_options[:protocol_version], proto_vsn)
+
+            state =
+              update_in(state.connection_options, &Keyword.put(&1, :protocol_version, proto_vsn))
+
             connect(state)
 
           {:error, reason} ->

diff --git a/lib/xandra/connection.ex b/lib/xandra/connection.ex
@@ -380,7 +380,8 @@ defmodule Xandra.Connection do
       send(state.cluster_pid, {:xandra, :disconnected, state.peername, self()})
     end
 
-    :ok = Transport.close(state.transport)
+    _transport = Transport.close(state.transport)
+    :ok
   end
 
   @impl true