Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch noproc errors #365

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Catch noproc errors #365

merged 7 commits into from
Apr 19, 2024

Conversation

harunzengin
Copy link
Contributor

@harunzengin harunzengin commented Apr 19, 2024 •
edited
Loading

Closes #359

whatyouhide
whatyouhide reviewed Apr 19, 2024
View reviewed changes
Copy link
Owner

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, looks great otherwise.

lib/xandra/connection_error.ex Outdated Show resolved Hide resolved
test/integration/errors_test.exs Outdated Show resolved Hide resolved
@whatyouhide whatyouhide merged commit 2a7dc8e into whatyouhide:main Apr 19, 2024
4 of 5 checks passed
@whatyouhide
Copy link
Owner

Thanks @harunzengin 💌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shutting down Cassandra node causes process exit
2 participants
@harunzengin @whatyouhide