Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external id to socket events #167

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add external id to socket events #167

merged 1 commit into from
Dec 11, 2023

Conversation

thyal
Copy link
Member

@thyal thyal commented Dec 8, 2023 •
edited
Loading

I added this yesterday, but apparently it disappeared during the rebase. Re-adding now.

Test plan

  1. Add externalId to roomConnectionOptions when calling useRoomConnection hook
  2. yarn dev
  3. Verify that externalId is passed to socket events (join_room and knock_room).

image

@thyal thyal requested a review from a team December 8, 2023 16:04
jamesdools-whereby
jamesdools-whereby approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jamesdools-whereby jamesdools-whereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@thyal thyal merged commit d741997 into development Dec 11, 2023
2 checks passed
@thyal thyal deleted the thomas/external-id branch December 11, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdools-whereby jamesdools-whereby jamesdools-whereby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thyal @jamesdools-whereby