Add initial custom events to rtcstats (for events timeline) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyal
reviewed
Dec 13, 2023
Comment on lines
288
to
293
| return ( | ||
| Object.entries(rtcAnalyticsCustomEvents) | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| .map(([_, value]) => value.actionType) | ||
| .includes(_action.type) | ||
| ); |
There was a problem hiding this comment.
Redux toolkit has this helper: isAnyOf, which you can use to check if an action is of a specific type.
I think we can do something like this:
const actions = Object.values(rtcAnalyticsCustomEvents).map((e) => e.action);
const isRtcEvent = isAnyOf(...actions);
return isRtcEvent(action);Requires some change in the events obj, but I think it should be straightforward. Just import the action creators directly and use those as the action instead of the string.
| const state: RootState = getState(); | ||
| const rtcManager = selectRtcConnectionRaw(state).rtcManager; | ||
|
|
||
| const rtcCustomEvent = Object.entries(rtcAnalyticsCustomEvents).find(([_, value]) => value.actionType === type); |
There was a problem hiding this comment.
Then we can use the same helper here:
const rtcCustomEvent = Object.values(rtcAnalyticsCustomEvents).find((value) =>
isAnyOf(value.action)(action)
);
Comment on lines
+27
to
+30
| actionType: "localParticipant/doEnableAudio/fulfilled", | ||
| rtcEventName: "audioEnabled", | ||
| getValue: (state: RootState) => selectIsMicrophoneEnabled(state), | ||
| getOutput: (value) => ({ enabled: value }), |
There was a problem hiding this comment.
Let's import the action creators and use them directly.
Suggested change
| actionType: "localParticipant/doEnableAudio/fulfilled", | |
| rtcEventName: "audioEnabled", | |
| getValue: (state: RootState) => selectIsMicrophoneEnabled(state), | |
| getOutput: (value) => ({ enabled: value }), | |
| action: doEnableAudio.fulfilled, | |
| rtcEventName: "audioEnabled", | |
| getValue: (state: RootState) => selectIsMicrophoneEnabled(state), | |
| getOutput: (value) => ({ enabled: value }), |
| @@ -10,3 +14,46 @@ export const rtcEvents = { | |||
| rtcManagerDestroyed: createRtcEventAction<void>("rtcManagerDestroyed"), | |||
| streamAdded: createRtcEventAction<RtcStreamAddedPayload>("streamAdded"), | |||
| }; | |||
|
|
|||
| type RtcAnalyticsCustomEvent = { | |||
| actionType: string; | |||
There was a problem hiding this comment.
see next comments of why.
Suggested change
| actionType: string; | |
| action: Matcher<UnknownAction>; |
jamesdools-whereby
force-pushed
the
jamesdooley/pan-645-add-initial-insights-events-needed-for-charts-microphone
branch
from
cd5a5de to
f13ba90
Compare
jamesdools-whereby
deleted the
jamesdooley/pan-645-add-initial-insights-events-needed-for-charts-microphone
branch
havardholvik
pushed a commit
that referenced
this pull request
Jan 8, 2024
* fix: localMediaSlice bug * Add sendStatsCustomEvent to rtc manager interface * Add reactor for rtc analytics custom events * Add screenshare button to storybook * Task: tidy customEvents object expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/whereby/issue/PAN-409/send-all-relevant-custom-events-to-rtc-stats
Test plan
yarn dev(can also compare to a normal room on prod / pwa to see the equivalent events)