Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rtcAnalytics slice and remaining rtcstats events #175

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Add rtcAnalytics slice and remaining rtcstats events #175

merged 5 commits into from
Jan 11, 2024

Conversation

jamesdools-whereby
Copy link
Contributor

@jamesdools-whereby jamesdools-whereby commented Jan 5, 2024 •
edited
Loading

https://linear.app/whereby/issue/PAN-646/forward-remaining-events-from-rtcanalyticscustomeventsconfig

Test plan

  • run yarn dev
  • Join room connection with local media story and join room
  • Test that initial custom events all fire at start of session in ws messages
  • Toggle mic, camera and screenshare actions
  • Verify that custom events appear after toggling
Screenshot 2024-01-08 at 09 04 49

@jamesdools-whereby jamesdools-whereby changed the title Jamesdooley/pan 646 forward remaining events from rtcanalyticscustomeventsconfig Forward remaining rtcstats events Jan 5, 2024
@jamesdools-whereby jamesdools-whereby changed the title Forward remaining rtcstats events Add rtcAnalytics slice and remaining rtcstats events Jan 5, 2024
@jamesdools-whereby jamesdools-whereby marked this pull request as ready for review January 8, 2024 09:05
@jamesdools-whereby jamesdools-whereby force-pushed the jamesdooley/pan-646-forward-remaining-events-from-rtcanalyticscustomeventsconfig branch from 1e79673 to 8fd816a Compare January 9, 2024 11:32
havardholvik
havardholvik approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@havardholvik havardholvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected. Just some minor comments. REMEMBER: re-target this to point to main before merging, as development might be stale at this point

src/lib/core/redux/slices/localParticipant.ts Outdated Show resolved Hide resolved
src/lib/core/redux/slices/rtcAnalytics.ts Show resolved Hide resolved
src/lib/core/redux/slices/rtcAnalytics.ts Show resolved Hide resolved
src/lib/core/redux/slices/rtcAnalytics.ts Show resolved Hide resolved
@jamesdools-whereby jamesdools-whereby changed the base branch from development to main January 10, 2024 11:59
@jamesdools-whereby jamesdools-whereby merged commit c773f31 into main Jan 11, 2024
2 checks passed
@jamesdools-whereby jamesdools-whereby deleted the jamesdooley/pan-646-forward-remaining-events-from-rtcanalyticscustomeventsconfig branch January 11, 2024 05:19
@thyal thyal mentioned this pull request Jan 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havardholvik havardholvik havardholvik approved these changes

@thyal thyal Awaiting requested review from thyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdools-whereby @havardholvik @thyal