-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto switch stream when device is unplugged #186
Conversation
263d27c
to
c1188dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflict you might want to resolve before this is reviewed @thyal 👍
c1188dd
to
0403e21
Compare
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Ive just reviewed the code now. Might be one thing for you to look at while I do manual testing before approval. Also remember to bump to the next beta version 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works as expected ✅
0403e21
to
b7db2f1
Compare
Bumped the version in #188 |
b7db2f1
to
fe342aa
Compare
fe342aa
to
e035012
Compare
Description
Sorry for the big PR on this small bugfix, but we didn't really handle switching of streams at all, so I had to add a bunch of logic. Also did some refactoring.
Summary:
Related Issue:
Testing
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Dependency Updates
Reviewers
@havardholvik
@kevinwhereby
@nandito
@thyal
Additional Information