-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle reversed streams from signaling #189
Handle reversed streams from signaling #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well, I haven't seen any issues when testing locally. There's some e2e tests failing, and some are related to screenshare. Could you look in to those? Let me know if you need a second pair of eyes.
Thank you, I'll take a look. |
@pnts-se-whereby when thinking about it, the tests are flaky sometimes. It's worth trying a re-run first |
The tests were actually flaky, but my fix was erroneous. |
…rstrom/cob-305-error-establishing-peer-connection-in-p2p-on-active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 Nice. Can verify that the bug happens on main
and that this fixes it
Handle reversed stream order in room_joined response when joining a P2P room with active screen share
Tested like:
pontusfagerstrom/cob-305-error-establishing-peer-connection-in-p2p-on-active
branch and run it in local-devready_to_receive_offer
been sent from the joining peer.ready_to_receive_offer
should be sent on join