Add sandbox attritube to iframe to allow downloads with new privacy s… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdools-whereby
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
I've just been testing the new local recording flow on my machine with both whereby-embed elements and plain iframes, and they download both current recordings and previously unsaved ones okay in the current context.
Not sure if we need to enable the sandbox anymore 🤔
| const isLocalRecordingEnabled = this.roomUrl.searchParams.has("recording"); | ||
|
|
||
| if (isLocalRecordingEnabled) | ||
| this.iframe.sandbox = "allow-downloads allow-same-origin allow-forms allow-scripts allow-popups"; |
There was a problem hiding this comment.
ps. I think this should be this.iframe.current.sandbox, perhaps with some conditional checks in there first
|
Closing this as it is no longer necessary since the rollout of our local recording fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…andbox settings
https://linear.app/whereby/issue/KOA-448/add-allow-downloads-to-the-iframe-injected-by-the-browser-sdk
Due to the upcoming privacy sandbox changes from Chrome, some issues are appearing when attempting to download local recordings from an iframe.
Adding 'allow-downloads' is the first piece of the work toward allowing users to download local-recordings from in room experience rather than getting redirecting to the dashboard. I also removed the 'speaker' attribute that is no longer supported in chrome.
Note:
Since these changes involve sandboxing the iframe, several other exemptions were required to allow the in room experience to remain unchanged
- EDIT: this should now only be applied if you have either the recording attribute on the embed element, or recording=on in the room url:
eg:
<whereby-embed recording room={roomUrl} />or:
<whereby-embed room="someroomurl.whereby.com?recording=on" />Test Plan