-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Notebook 1 #16
base: main
Are you sure you want to change the base?
Conversation
…ssociated map config JSON files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice. Great work!
Why doesnt this replace the first example you see when you open the notebook? |
@mbforr I made a few commits for content clarity and some markdown/formatting changes. |
python/onboarding/Wherobots Onboarding Part 1 - Loading Data.ipynb
Outdated
Show resolved
Hide resolved
python/onboarding/Wherobots Onboarding Part 1 - Loading Data.ipynb
Outdated
Show resolved
Hide resolved
We can do that - thoughts @kadolor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
python/onboarding/Wherobots Onboarding Part 1 - Loading Data.ipynb
Outdated
Show resolved
Hide resolved
@kadolor thanks for taking a look - these look good to me. Do you do the merge or should I? |
To streamline our onboarding materials, we should consider merging I think that currently,
We can create an Notion bug to track this and ensure content parity between notebooks before combining those two notebooks. As a temporary solution and to aid in discoverability, we could add a section and link to @dwyliebot Do you have any thoughts on replacing |
You can merge it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use space in file names.
@james-willis @mbforr I spoke with Damian earlier today and I actually think that going forward with We can iterate on the notebook to include any missing information if we find that it's necessary. What code changes need to be made so that
|
@kadolor The default notebook is hard-coded here: https://github.com/wherobots/wbc-k8s-recipe/blob/2c59c6d520f580b92a30597112ad154e03eae874/helm-charts/jupyter-spark-lab/templates/configmaps.yaml#L139 What do you want to to do? Replace the |
@jiayuasu The goal here would be to replace the |
@jiayuasu Can you give me write access to the
|
@kadolor Done. Any change in helm-chart needs to bump the version. See example: https://github.com/wherobots/wbc-k8s-recipe/pull/196/files Please consult Zongsi for review. |
Adding in the /Wherobots Onboarding Part 1 - Loading Data.ipynb and associated map config JSON files