Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Notebook 1 #16

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Onboarding Notebook 1 #16

wants to merge 10 commits into from

Conversation

mbforr
Copy link

@mbforr mbforr commented Jan 10, 2025

Adding in the /Wherobots Onboarding Part 1 - Loading Data.ipynb and associated map config JSON files

@jiayuasu jiayuasu requested a review from kadolor January 10, 2025 22:46
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. Great work!

@james-willis
Copy link
Contributor

Why doesnt this replace the first example you see when you open the notebook?

@kadolor
Copy link

kadolor commented Jan 14, 2025

@mbforr I made a few commits for content clarity and some markdown/formatting changes.

@mbforr
Copy link
Author

mbforr commented Jan 14, 2025

Why doesnt this replace the first example you see when you open the notebook?

We can do that - thoughts @kadolor?

Copy link
Author

@mbforr mbforr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbforr
Copy link
Author

mbforr commented Jan 14, 2025

@kadolor thanks for taking a look - these look good to me. Do you do the merge or should I?

@kadolor
Copy link

kadolor commented Jan 14, 2025

Why doesnt this replace the first example you see when you open the notebook?

We can do that - thoughts @kadolor?

@james-willis @mbforr

To streamline our onboarding materials, we should consider merging FirstWherobotsNotebook.ipynb into python/onboarding/Wherobots Onboarding Part 1 - Loading Data.ipynb in the future.

I think that currently, FirstWherobotsNotebook.ipynb provides a more foundational introduction to the following:

  • The Wherobots Open Data Catalog
  • Spatial SQL
  • SedonaContext and its extension of Spark

We can create an Notion bug to track this and ensure content parity between notebooks before combining those two notebooks.

As a temporary solution and to aid in discoverability, we could add a section and link to FirstWherobotsNotebook.ipynb that points to readers to Onboarding Notebook 1.ipynb. Thoughts?

@dwyliebot Do you have any thoughts on replacing FirstWherobotsNotebook.ipynb with Onboarding Part 1 - Loading Data.ipynb ?

@kadolor
Copy link

kadolor commented Jan 14, 2025

@kadolor thanks for taking a look - these look good to me. Do you do the merge or should I?

You can merge it. Thanks!

kadolor
kadolor previously approved these changes Jan 14, 2025
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use space in file names.

@jiayuasu
Copy link
Member

@mbforr @kadolor Can you fix my comment and let's merge it?

@kadolor
Copy link

kadolor commented Jan 23, 2025

@jiayuasu @mbforr I just pushed the change to edit the filename. @mbforr I believe you mentioned that you were trying to merge this into 1.5.0? Can you confirm the next steps?

@kadolor
Copy link

kadolor commented Jan 23, 2025

@james-willis @mbforr I spoke with Damian earlier today and I actually think that going forward with python/onboarding/WherobotsOnboardingPart1.ipynb right now makes sense.

We can iterate on the notebook to include any missing information if we find that it's necessary.

What code changes need to be made so that python/onboarding/WherobotsOnboardingPart1.ipynb is the default notebook for new users of Wherobots?

Why doesnt this replace the first example you see when you open the notebook?

We can do that - thoughts @kadolor?

@james-willis @mbforr

To streamline our onboarding materials, we should consider merging FirstWherobotsNotebook.ipynb into python/onboarding/Wherobots Onboarding Part 1 - Loading Data.ipynb in the future.

I think that currently, FirstWherobotsNotebook.ipynb provides a more foundational introduction to the following:

  • The Wherobots Open Data Catalog
  • Spatial SQL
  • SedonaContext and its extension of Spark

We can create an Notion bug to track this and ensure content parity between notebooks before combining those two notebooks.

As a temporary solution and to aid in discoverability, we could add a section and link to FirstWherobotsNotebook.ipynb that points to readers to Onboarding Notebook 1.ipynb. Thoughts?

@dwyliebot Do you have any thoughts on replacing FirstWherobotsNotebook.ipynb with Onboarding Part 1 - Loading Data.ipynb ?

@jiayuasu
Copy link
Member

@kadolor The default notebook is hard-coded here: https://github.com/wherobots/wbc-k8s-recipe/blob/2c59c6d520f580b92a30597112ad154e03eae874/helm-charts/jupyter-spark-lab/templates/configmaps.yaml#L139

What do you want to to do? Replace the FirstWherobotsNotebook or have both exist but defaults to OnboardingNotebook1?

@kadolor
Copy link

kadolor commented Jan 24, 2025

@jiayuasu The goal here would be to replace the FirstWherobotsNotebook.

@kadolor
Copy link

kadolor commented Jan 27, 2025

@jiayuasu Can you give me write access to the wbc-k8s-recipe repository? Currently, I'm not able to push the change

@kadolor The default notebook is hard-coded here: https://github.com/wherobots/wbc-k8s-recipe/blob/2c59c6d520f580b92a30597112ad154e03eae874/helm-charts/jupyter-spark-lab/templates/configmaps.yaml#L139
...

@jiayuasu
Copy link
Member

@kadolor Done. Any change in helm-chart needs to bump the version. See example: https://github.com/wherobots/wbc-k8s-recipe/pull/196/files Please consult Zongsi for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants