Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .tag files #178

Closed
cal2195 opened this issue May 9, 2019 · 10 comments
Closed

Implement .tag files #178

cal2195 opened this issue May 9, 2019 · 10 comments
Assignees
Labels
feature request New features
Milestone

Comments

@cal2195
Copy link
Collaborator

cal2195 commented May 9, 2019

A nice feature to have is the ability to import tags from .tag files which are located with the videos - eg. video.mp4 and video.mp4.tag

This tag file would store comma seperated values of tags, and the app can load in these tags automatically into the manual tags field when importing to files!

This allows you to script any number of things to scrape, or generate tags for files and then add them to the app easily! Writing out current tags to the tag files would also be a nice option! 💡

I've already got this working, just need to think about when to import tags, if the file is already tagged - Currently it only imports if there are no tags on a particular file. 👍

@cal2195 cal2195 added the feature request New features label May 9, 2019
@cal2195 cal2195 self-assigned this May 9, 2019
@whyboris
Copy link
Owner

whyboris commented May 9, 2019

I've never heard of .tag files 😮
In what OS is this available?
Could you share any documentation/summary about them?

@cal2195
Copy link
Collaborator Author

cal2195 commented May 9, 2019

I just invented them! 😆 I figured it was a fairly simple way to allow people to interface from their favourite programming language to automatically tag the video files in whatever way they wanted, and then have the ability to magically import all the tags into vha! 💡

@whyboris
Copy link
Owner

whyboris commented May 9, 2019

I see 👍

I'm reluctant to fill up people's directories with new files (even if they are hidden 😓), but if the suggestion is to allow VHA to extract tags from those files, that could work.

@cal2195
Copy link
Collaborator Author

cal2195 commented May 9, 2019

Well no - I agree and this is completely optional - you could choose whether to import .tag files if present, and exporting the tag files would be an option in the settings! More for backup/regenerating libraries! 👍

@whyboris
Copy link
Owner

whyboris commented May 9, 2019

I feel like we might need some secret dev mode :trollface:
https://www.youtube.com/watch?v=pXPXMxsXT28

@whyboris whyboris added this to the Ideas milestone Aug 18, 2019
@whyboris
Copy link
Owner

@cal2195 -- I'm thinking of cleaning up the Issues page to keep it ready for after Version 2 release.

You said you had some version of this implemented, though I also think it's the kind of feature that would at best be used by only a few people.

It sounds like it may be as simple as a single function that checks whether there is a .tag available and attaches the tags to the ImageElement. On the front-end you might need to merge the flags or ignore them 🤷‍♂ So I'm not opposed to merging a PR - as long as it doesn't cause any bugs 🙆‍♂

Please feel free to re-open the issue as you see fit 🤝

This was referenced Nov 18, 2019
@cal2195
Copy link
Collaborator Author

cal2195 commented Nov 19, 2019

Reopening as there seems to be continued interest in some feature like this. 👍

@cal2195 cal2195 reopened this Nov 19, 2019
@whyboris
Copy link
Owner

whyboris commented Feb 21, 2020

I had another user email me with a request to import tags attached to files that can be seen in the OS.

Seems like this might do the trick:
https://github.com/keichi/osx-tag

It works well on Mac 👌
Probably should add a toggle whether to import these or not 😓 ...

PR ready: #370 -- but is WIP (need the UI and want to add Windows support) 😅

@whyboris
Copy link
Owner

⚠️ this dependency can't be installed on Windows and I would have to maintain a mac branch in order for this feature to exist. This isn't a problem, but I think this may be a mac-only feature for a while.

@whyboris
Copy link
Owner

I figured out a way to import OS-X tags on first scan. I'll try to get this PR #370 merged before VHA 3.0.0 is released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features
Projects
None yet
Development

No branches or pull requests

2 participants