Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npm with yarn; add CI workflow to run TSC and tslint checks #699

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Check

on: push

jobs:
check:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2

- name: Use Node.js 14.x
uses: actions/setup-node@v2
with:
node-version: 14.x

- name: Get Node.js version
id: get-node-version
run: echo "::set-output name=node-version::$(node --version)"

- name: Install Yarn
if: ${{ env.ACT }}
run: npm install yarn --global

- name: Get yarn cache directory path
id: get-yarn-cache-path
run: |
yarn cache dir
echo "::set-output name=yarn-cache-path::$(yarn cache dir)"

- uses: actions/cache@v2
id: yarn-cache
with:
path: ${{ steps.get-yarn-cache-path.outputs.yarn-cache-path }}
key: ${{ runner.os }}_node-${{ steps.get-node-version.outputs.node-version }}_yarn-${{ hashFiles('**/yarn.lock') }}

- name: 📦 Install Dependencies
run: yarn install --frozen-lockfile

- name: 🔍 Check
run: yarn run check
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ See [issues](https://github.com/whyboris/Video-Hub-App/issues) for what is in pr

How to start:

- `npm install` to install
- `npm start` to develop
- `npm run electron` to build
- `npm install -g yarn` to install yarn globally
- `yarn install` to install
- `yarn start` to develop
- `yarn run electron` to build

Main dependencies in use:

Expand Down
2 changes: 1 addition & 1 deletion demo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This folder contains files for showing a web preview of the app.

First build the app (`npm run build`) with the web-demo flag `webDemo` set to `true` (in `home.component.ts`). This should populate the `/dist` folder with `index.html`.
First build the app (`yarn run build`) with the web-demo flag `webDemo` set to `true` (in `home.component.ts`). This should populate the `/dist` folder with `index.html`.

Now when you open the `index.html` within this folder, you should see a web version of the app with sample demo content.

Expand Down
Loading