Add support for RIPEMD160 digest #55
Conversation
There was a problem hiding this comment.
Thanks for the contribution!
Let's start with just supporting RIPEMD160, as it's supported in at least 2 providers.
This is some kind of "rule" at my side, as I don't see a reason currently to support algorithms, which are available only on one platform (may change in future).
Plus, as far as I understand, only RIPEMD160 is widely used
huskcasaca
changed the title
| include: | ||
| - os: 'macos-latest' | ||
| target: 'macos' | ||
| - os: 'windows-latest' | ||
| target: 'native' | ||
| - os: 'ubuntu-24.04' |
There was a problem hiding this comment.
is there some problem with ubuntu-latest?
There were no problems before, so I don't think that it's needed for this PR
Could you please revert those changes and I will re-run CI?
There was a problem hiding this comment.
I tried not to change but ubuntu-latest is 22.04 which is using OpenSSL 3.0.2. It dropped RIPEMD160 to legacy providers which requires an extra config file to reenable it otherwise the CI will fail.
But OpenSSL 3.0.6 reverts the drop so I have to update to ubuntu-24.04 with OpenSSL 3.0.8+.
openssl/openssl#16994
https://openssl-library.org/news/openssl-3.0-notes/
There was a problem hiding this comment.
Okay, I see, thanks for the explanation!
| include: | ||
| - os: 'macos-latest' | ||
| target: 'macos' | ||
| - os: 'windows-latest' | ||
| target: 'native' | ||
| - os: 'ubuntu-24.04' |
There was a problem hiding this comment.
Okay, I see, thanks for the explanation!
RIPEMD160 is widely used and supported by BouncyCastle and OpenSSL3. However, RIPEMD128, RIPEMD256, and RIPEMD320 are not supported by OpenSSL3. I'm not sure if it’s necessary to add the others.