[FR-305] Fix: Embeds are not properly responsive #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yomanz
requested changes
Mar 25, 2025
bibakroy
force-pushed
the
fix/youtube-embed
branch
from
9119eb5 to
ee4dca5
Compare
added 3 commits
March 29, 2025 16:44
bibakroy
changed the title
…e layout on small screens
JohnyTheCarrot
requested changes
Mar 31, 2025
src/Content/Embed/index.tsx
Outdated
Comment on lines
151
to
157
| // <Styles.Images nImages={images.length}> | ||
| // {images.map((image) => ( | ||
| // <Styles.ImageGridImageContainer key={image.url}> | ||
| // <EmbeddedImage embedImage={image} withMargin /> | ||
| // </Styles.ImageGridImageContainer> | ||
| // ))} | ||
| // </Styles.Images> |
There was a problem hiding this comment.
Why not just remove it?
There was a problem hiding this comment.
I'd personally opt for making a const like MAX_IMAGES, then we can use images.slice(0, MAX_IMAGES)
since we may want to allow showing 4 images at some point
@JohnyTheCarrot This change is made automatically when I run |
added 2 commits
April 2, 2025 19:41
…e layout on small screens
…derer into fix/youtube-embed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.