Follow redirects when notifying users #322
Conversation
Fixes wikimedia-gadgets#90 Advantages - Simpler than patch wikimedia-gadgets#291 - The original intent of the function notifyUser was to follow redirects, indicated by the comment "Follows redirects and appends a message to the bottom of the user's talk page." from 2014. So this fixes that bug. Disadvantages - Will only follow 1 redirect, not 2+ redirects. - The "Saved [[User talk:OldUsername]] (diff)" message shown to the AFC reviewer will be slightly incorrect. The diff will be correct, but OldUsername should ideally be NewUsername.
|
I don't really care which of these two patches (this one or #291) gets merged. They both have pros and cons as mentioned in the advantages and disadvantages section above. @siddharthvp or anyone else, do you have a preference? Let's get one of these merged so this is unstuck. |
|
Very rarely will there be two redirects, so I am less concerned about that. The "old" username showing is a bit naff, but if anyone clicks on it they'll be redirected anyway so it's probably not a huge deal. I'm a huge fan of simplicity, but if the other patch can deal with both of these issues, I suppose we go with that? |
|
I'm planning to abandon this patch on Monday in favor of #291 unless there are more comments over the weekend. |
There won't ever be 2+ redirects, right? There are bots that automatically simplify double redirects as MW itself follows upto 1 redirect only.
This doesn't seem like a real disadvantage. It's common to refer to a page via a redirect name, and that's assuming anyone pays attention to the message. |
|
I think this is good to go for now and doesn't preclude #291 - although I'm not a fan of the extra API calls and complexity it introduces. |
Fixes #90
Advantages
Disadvantages