-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WikiProject banner shell on draft talk pages #365
Merged
NovemLinguae
merged 18 commits into
wikimedia-gadgets:master
from
NovemLinguae:talk-page-wikitext
Aug 23, 2024
Merged
Use WikiProject banner shell on draft talk pages #365
NovemLinguae
merged 18 commits into
wikimedia-gadgets:master
from
NovemLinguae:talk-page-wikitext
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix wikimedia-gadgets#319 Implement WP:PIQA (put the article's class rating in the banner shell instead of in the wikiproject templates) - Fix wikimedia-gadgets#73 Multiple WikiProject banners should be collapsed in {{WikiProject banner shell}} - In unit tests, switch from single quotes to backticks, for increased multi-line readability.
ptsgrn
pushed a commit
to ptsgrn/afch-rewrite
that referenced
this pull request
Dec 4, 2024
* allow es6 in test files (since they use node) * make existing test strings multi-line, for readability * add banner shell if needed * Use WikiProject banner shell on draft talk pages - Fix wikimedia-gadgets#319 Implement WP:PIQA (put the article's class rating in the banner shell instead of in the wikiproject templates) - Fix wikimedia-gadgets#73 Multiple WikiProject banners should be collapsed in {{WikiProject banner shell}} - In unit tests, switch from single quotes to backticks, for increased multi-line readability. * fix linter errors * fix regex bug * add a banner shell, even if there's only 1 wikiproject * handle existing banner shell * remove extra line breaks between banners * add test case * add template redirect I saw in the wild today * add test. mark it as skipped since it's failing * tweak comments * completely rewrite AFCH.addTalkPageBanners() * get rid of "X banners added" edit summary code. simplifies things * remove 3 unused parameters from AFCH.addTalkPageBanners * fix linter errors * simplify AFCH.addTalkPageBanners return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major existing bugs not fixed in this patch
New bugs introduced by this patch (may fix later if they are common)