Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WikiProject banner shell on draft talk pages #365

Merged
merged 18 commits into from
Aug 23, 2024

Conversation

NovemLinguae
Copy link
Member

@NovemLinguae NovemLinguae commented Aug 21, 2024

Major existing bugs not fixed in this patch

New bugs introduced by this patch (may fix later if they are common)

  • Nested templates are likely to cause bugs
  • Parameters in old banners or old shells may be deleted, overwritten with a simpler banner or shell

@NovemLinguae NovemLinguae merged commit 655a71a into wikimedia-gadgets:master Aug 23, 2024
2 checks passed
ptsgrn pushed a commit to ptsgrn/afch-rewrite that referenced this pull request Dec 4, 2024
* allow es6 in test files (since they use node)

* make existing test strings multi-line, for readability

* add banner shell if needed

* Use WikiProject banner shell on draft talk pages

- Fix wikimedia-gadgets#319 Implement WP:PIQA (put the article's class rating in the banner shell instead of in the wikiproject templates)
- Fix wikimedia-gadgets#73 Multiple WikiProject banners should be collapsed in {{WikiProject banner shell}}
- In unit tests, switch from single quotes to backticks, for increased multi-line readability.

* fix linter errors

* fix regex bug

* add a banner shell, even if there's only 1 wikiproject

* handle existing banner shell

* remove extra line breaks between banners

* add test case

* add template redirect I saw in the wild today

* add test. mark it as skipped since it's failing

* tweak comments

* completely rewrite AFCH.addTalkPageBanners()

* get rid of "X banners added" edit summary code. simplifies things

* remove 3 unused parameters from AFCH.addTalkPageBanners

* fix linter errors

* simplify AFCH.addTalkPageBanners return values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment