Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature branch] Year-in-review #5370

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[Feature branch] Year-in-review #5370

wants to merge 12 commits into from

Conversation

voyagerfan
Copy link
Contributor

@voyagerfan voyagerfan commented Mar 3, 2025 •
edited
Loading

What does this do?

Adds Year-in-review entry point to the More menu of the Explore feed

Why is this needed?

Supports task T387595 for EPIC T387034

Phabricator:
https://phabricator.wikimedia.org/T387034
https://phabricator.wikimedia.org/T387595

cooltey
cooltey requested changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this feature branch! Just have some review comments:

@cooltey cooltey added WIP Work in progress HOLD Will review as soon as other more pressing PRs are merged/released. labels Mar 4, 2025
@voyagerfan voyagerfan requested a review from cooltey March 4, 2025 19:57
voyagerfan and others added 4 commits March 6, 2025 14:15
@voyagerfan
T387803 - Build Jetpack Compose NavHost and first YiR screen (#5381)
a74340f 
* update dependencies, manifest. Add yearinreview package with navigation and test screen

* fix linting errors

* fix remaining linting error

* removed 'exported' attribute and added BaseTheme to the NavHost testscreen
@voyagerfan
Create clickable navigation for the year in review entry point: T387804…
940eec3 
… (#5385)

* Created ClickListner for 'Year in Review' selection and linked to YearInReviewActivity

* modified newIntent and yearInReviewClick() to remove the userName as a parameter
@voyagerfan
merge main with yearInReview_design and resolved conflicts
03cfc21
@cooltey
Merge branch 'main' into yearInReview_design
f8c7178 
* main:
  Reduce ANRs: make all HistoryEntry DAO functions suspend. (#5419)
  Bump the kotlin-ksp group with 6 updates (#5416)
  Fix: license links do not match the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@Williamrai Williamrai Awaiting requested review from Williamrai Williamrai is a code owner

@cooltey cooltey Awaiting requested review from cooltey cooltey is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
HOLD Will review as soon as other more pressing PRs are merged/released. WIP Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voyagerfan @cooltey