fix: update html cleaning rules #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ziafazal Please review. |
ziafazal
reviewed
Jul 4, 2024
There was a problem hiding this comment.
@ahmed-arb overall looks good few minor things to look into. Please add unit tests too.
ahmed-arb
force-pushed
the
ahmed-arb/fix-html-clean
branch
from
a55f99b to
592c7e3
Compare
|
@ziafazal please review again. |
ziafazal
reviewed
Jul 5, 2024
| @@ -20,7 +20,6 @@ class MessengerConfig(AppConfig): | |||
| PluginSettings.CONFIG: { | |||
| ProjectType.LMS: { | |||
| SettingsType.COMMON: {PluginSettings.RELATIVE_PATH: 'settings.common'}, | |||
| SettingsType.TEST: {PluginSettings.RELATIVE_PATH: 'settings.test'}, | |||
There was a problem hiding this comment.
This module does not exist.
ziafazal
reviewed
Jul 5, 2024
ahmed-arb
force-pushed
the
ahmed-arb/fix-html-clean
branch
from
ec0572d to
c37c050
Compare
|
@ziafazal Please review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
OpenEdx uses Cleaner from LXML to sanitize HTML before displaying it on the about page. It removes URLs if they contain JavaScript. The decision rule matches the following schemes in the URL:
Solution:
We override the rule to bypass cleaning if
hrefvalue is a URL.