Add search bar (and additional tweaks) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Establish a consistent style across views - Improve HTML semantics - Tweak text to decrease repetition
No need to include static information in the component Also, this maintains structural consistency across the different views. (And it makes it easier for me to add the search bar as a child component.)
"Home.vue" did not accurately describe the component's usage Removed more static text Removed unnecessary HTML nesting
Can now GET tasks by tool name
Previously, the usage instructions weren't accessible on mobiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm extremely pleased to report that I managed to get a working search bar implemented during the Wikimedia Hackathon.
I'm somewhat less pleased to report (or, rather, you all may be less pleased to hear) that I've done my usual mixing-issues thing and addressed a few other issues while I was at it, namely making some visual and grammatical tweaks.
This PR addresses T332910, T333928, and T333358
It requires wikimedia/toolhunt#61 on the backend.