-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELY-2769 Update CI to also run with SE 21 for branch 2.2.x #2153
Conversation
.github/workflows/pr-ci.yaml
Outdated
@@ -15,12 +15,13 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest, macos-latest] | |||
java: ['11', '17', '21'] | |||
steps: | |||
- uses: actions/checkout@v2 | |||
- name: Set up JDK 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated too (see #2142)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fjuma
It looks like there are some test failures with Java 17 on this branch: https://github.com/wildfly-security/wildfly-elytron/actions/runs/9288164876/job/25558904163?pr=2153#step:6:4956
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if the failures are the same as the ones tracked here:
https://issues.redhat.com/browse/ELY-2760
The issues linked to ELY-2760 will need to be merged first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is related to https://issues.redhat.com/browse/ELY-2763.
I will add a note here that it depends on https://issues.redhat.com/browse/ELY-2760
Thanks!
https://issues.redhat.com/browse/ELY-2769
Depends on issues tracked through https://issues.redhat.com/browse/ELY-2760
Related issue: https://issues.redhat.com/browse/ELY-2727
Related PR: #2103