Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2775] Rename the configuration files as they are specific to the test cases. #2164

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Jun 26, 2024

Looking at these files we got into a trend of using versioned names but these files are not actually a part of XML version parsing so are better suited to have a name that reflects the test and a comment to identify the test class as well.

https://issues.redhat.com/browse/ELY-2775

@darranl darranl marked this pull request as ready for review June 26, 2024 14:25
@darranl darranl requested review from fjuma and Skyllarr as code owners June 26, 2024 14:25
@fjuma
Copy link
Contributor

fjuma commented Jul 8, 2024

@darranl Just FYI, this one has some conflicts now.

@darranl
Copy link
Contributor Author

darranl commented Jul 8, 2024

@fjuma FYI I have just pushed another commit that should fix that.

@fjuma
Copy link
Contributor

fjuma commented Jul 9, 2024

Thanks @darranl!

@fjuma fjuma merged commit 0c24b3f into wildfly-security:2.x Jul 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants