[WFLY-20383] Get rid of compiler warnings #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kabir FYI the test with deps (i.e. with wildfly main) gets into a deadend, please see https://github.com/wildfly/quickstart/actions/runs/13520048394/job/37788930160?pr=1020 |
|
I have triggered another run to double check |
Also fix BroadcastPublisher.onError()
|
@emmartins Should be good now (and thanks @jamezp for the assistance!) |
jamezp
approved these changes
Feb 27, 2025
| @@ -45,7 +45,7 @@ public UserMessagingBean() { | |||
|
|
|||
| @Inject | |||
| public UserMessagingBean(@Channel("user") Publisher<String> receiver) { | |||
| this.broadcastPublisher = new BroadcastPublisher(receiver); | |||
| this.broadcastPublisher = new BroadcastPublisher<String>(receiver); | |||
There was a problem hiding this comment.
Not critical, but this could just be new BroadcastPubliser<>(receiver);.
| @Override | ||
| public void onSubscribe(Subscription subscription) { | ||
| baseSubscription = subscription; | ||
| subscription.request(1); | ||
| } | ||
|
|
||
| @Override | ||
| public void onNext(Object o) { | ||
| public void onNext(T o) { | ||
| System.out.println("Received " + o + " - forwarding it to all the subscribers"); |
There was a problem hiding this comment.
Not part of this change, but a System.out.println() should not be used.
emmartins
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix BroadcastPublisher.onError()
https://issues.redhat.com/browse/WFLY-20383