[WFLY-20447] Fix mistakes in "http custom mechanism" readme

[mskacelik]

Issue: https://issues.redhat.com/browse/WFLY-20447

While going through this quickstart I probably found some mistakes in the readme.

• wrong path (.../modules/modules/...)
• one section is copy pasted and is twice in the text
• no mention of the restoring scripts

Also bit off topic, but how exactly does the password validation work for the custom mechanism, given that X-PASSWORD could be anything and response is still OK (200) (unlike the X-USERNAME)

[emmartins]

hi @mskacelik, thanks for this. I have a few changes to request, you should only change README-source.adoc, the README.adoc is just a flattened version of README-source.adoc that is auto updated after each PR merge.

So the other README.adoc changes you did should actually be around the following include, that is wrongly done twice:

:restoreScriptName: restore-configuration.cli
include::../shared-doc/restore-standalone-server-configuration-manual.adoc[leveloffset=+2]

The problem here is that such "included" content does not really supports multiple scripts, so now you may just remove the second include (line 238), and I will create a new JIRA to add multiple script support to that shared docs content; alternatively you can do that extra too in this PR, by improving the /shared-doc/restore-standalone-server-configuration-manual.adoc now.

[emmartins]

@mskacelik by the way, do you have already a WildFly JIRA account? I created a JIRA for your contribution at https://issues.redhat.com/browse/WFLY-20447 , if you have an account I may assign it to you, otherwise I can help as proxy, no prob.

[emmartins]

@fjuma it's a bit unusual place for user requests, but perhaps you want to reply here to @mskacelik , please see his question in issue description?

[mskacelik]

Ah, that makes sense, thank you.

alternatively you can do that extra too in this PR

Yea sure, could give it a try. :)

by the way, do you have already a WildFly JIRA account?

Yes I do, Marek Skacelik ([email protected])

[mskacelik]

hi @mskacelik, thanks for this. I have a few changes to request, you should only change README-source.adoc, the README.adoc is just a flattened version of README-source.adoc that is auto updated after each PR merge.

So the other README.adoc changes you did should actually be around the following include, that is wrongly done twice:

:restoreScriptName: restore-configuration.cli
include::../shared-doc/restore-standalone-server-configuration-manual.adoc[leveloffset=+2]

The problem here is that such "included" content does not really supports multiple scripts, so now you may just remove the second include (line 238), and I will create a new JIRA to add multiple script support to that shared docs content; alternatively you can do that extra too in this PR, by improving the /shared-doc/restore-standalone-server-configuration-manual.adoc now.

Shouldn't the included file on line 226 be: restore-standalone-server-configuration.adoc instead of restore-standalone-server-configuration-manual.adoc? This explains the :restoreScriptName: restore-configuration.cli above it as a parameter (in the manual, restoreScriptName is not used) and also why the manual is included below it (since it continues the non-manual section nicely).

[emmartins]

@mskacelik thank you :-)