-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "Docker and Kubernetes" category in Guides #676
base: main
Are you sure you want to change the base?
New "Docker and Kubernetes" category in Guides #676
Conversation
_data/guides.yaml
Outdated
- title: Java Microservices on Kubernetes with WildFly | ||
url: /guides/get-started-microservices-on-kubernetes | ||
description: Build and run Jakarta EE applications with WildFly on Kubernetes in a few minutes | ||
- category: Docker and Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Containers
instead?
I think we should move away from using the Docker (which is one of the tool to build & run containers but there are others such as Podman) and focus on the container (which is also what is run by Kubernetes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmesnil Thank you for your suggestion! that was somewhat intentional: the assumption is that most audience knows what Docker is but might be confused by the term "container" alone .... the guides actually use Podman and specify that Docker can be used as an alternative .... my assumption might be wrong (I did it based solely on my personal experience): let me know if you want to switch to "Podman" or "Container"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to bump this discussion forward - @jmesnil do you still stand by your comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmesnil changed to "Podman/Docker and Kubernetes" ... I've seen this around ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tommaso-borgato Sounds reasonable to me. 👍🏼 Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said on the chat, please don't call this Docker. It's a private closed-source company with proprietary software. Use 'Containers' when speaking generally.
6a17e8b
to
b4bd3af
Compare
@rhusar what about #676 (comment) ? |
ea25cb4
to
42a8d1c
Compare
_includes/index-guides.html
Outdated
</div> | ||
</div> | ||
{% endfor %} | ||
{% else %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
{% endif %}
{% if item.guides %}
Otherwise the entire category must be used solely for guides that are part of groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bstansberry Thank you
This will conflict with #712 and will need to be updated to put the new category in the correct alphabetical position. |
42a8d1c
to
41fd440
Compare
41fd440
to
5992698
Compare
5992698
to
825ed92
Compare
825ed92
to
2368702
Compare
@bstansberry I have just re-based ans resolved conflicts: do you think we can merge this one now or assign a reviewer? |
Just wanted to add that at the OKR3 meeting, we distilled this category, among others, as "Cloud/Containerization". The full document with the categories we got is here: https://docs.google.com/document/d/1JoxoqN9Z5adpdNkTrWPdjLN3BroB4cBmV2ABYs-lm2I/edit?tab=t.0 It was just the point of view of the people who have been participating in the OKR3, it doesn't mean this PR should not be merged as it is because of that. In any case, as commented on #676 (review), the "docker" word for a category, I would say it is better not to use it at all. |
Thank you @yersan : I changed the name and here is how it looks now: |
2368702
to
276c368
Compare
NOTE: You can use link:https://docs.wildfly.org/wildfly-maven-plugin/releases/{version-wildfly-maven-plugin-docs}/image-mojo.html[`wildfly-maven-plugin`, window="_blank"] to automate the image push to an image registry | ||
|
||
NOTE: You can use link:https://docs.wildfly.org/wildfly-maven-plugin/releases/{version-wildfly-maven-plugin-docs}/image-mojo.html[`wildfly-maven-plugin`, window="_blank"] to automate the image push to an image registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears duplicated?
Thank you @rhusar ! Fixed
64f8913
to
d5cef8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_data/guides.yaml
Outdated
url: /guides/get-started-microservices-on-kubernetes | ||
description: Build and run Jakarta EE applications with WildFly on Kubernetes in a few minutes | ||
- category: Cloud / Containerization | ||
cat-id: docker-kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of docker
also from the category id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhusar Tnks, changed
d5cef8b
to
40e6e52
Compare
This PR moves the "WildFly mini Series" index up one level into the "Guides" page by creating a new "Docker and Kubernetes" category:
"Draft" because this MR is based upon #671 and has to be re-based & merged afterwards