Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve arguments of get_patrols #275

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Improve arguments of get_patrols #275

merged 5 commits into from
Sep 30, 2024

Conversation

Yun-Wu
Copy link
Contributor

@Yun-Wu Yun-Wu commented Sep 30, 2024

  • format since and until timestamp
  • add invalid format
  • Support patrol type values
  • comment

This was linked to issues Sep 30, 2024
Fetch patrols by patrol type instead of UUIDs #271
Closed
get_patrol_observations: since/until not working wildlife-dynamics/ecoscope-workflows#234
Closed
atmorling
atmorling approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@atmorling atmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yun-Wu Yun-Wu merged commit 45aa020 into master Sep 30, 2024
5 checks passed
@Yun-Wu Yun-Wu deleted the patrol branch September 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmorling atmorling atmorling approved these changes

@walljcg walljcg Awaiting requested review from walljcg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch patrols by patrol type instead of UUIDs get_patrol_observations: since/until not working
2 participants
@Yun-Wu @atmorling