Rewrite night day ratio algorithm #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmorling
approved these changes
Nov 15, 2024
Comment on lines
+59
to
+79
| def calculate_day_night_distance(date, segment_start, segment_end, dist_meters, daily_summary): | ||
| sunrise = daily_summary.loc[date, "sunrise"] | ||
| sunset = daily_summary.loc[date, "sunset"] | ||
|
|
||
| if segment_start < sunset and segment_end > sunset: # start in day and end in night | ||
| day_percent = (sunset - segment_start) / (segment_end - segment_start) | ||
| elif segment_start < sunrise and segment_end > sunrise: # start in night and end in day | ||
| day_percent = (segment_end - sunrise) / (segment_end - segment_start) | ||
| elif sunrise < sunset: | ||
| if segment_end < sunrise or segment_start > sunset: # all night | ||
| day_percent = 0 | ||
| elif segment_start >= sunrise and segment_end <= sunset: # all day | ||
| day_percent = 1 | ||
| else: # sunrise >= sunset | ||
| if segment_end < sunset or segment_start > sunrise: # all day | ||
| day_percent = 1 | ||
| elif segment_start >= sunset and segment_end <= sunrise: # all night | ||
| day_percent = 0 | ||
|
|
||
| daily_summary.loc[date, "day_distance"] += day_percent * dist_meters | ||
| daily_summary.loc[date, "night_distance"] += (1 - day_percent) * dist_meters |
There was a problem hiding this comment.
I love this. So much clearer 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314