Add entity Main Breaker Current Limit #1140
Conversation
|
I can't test on a G5, but according to the docs it's the same as the G4. |
| register = 0x71, | ||
| fmt = "i", | ||
| native_min_value = 10, | ||
| native_max_value = 250, |
There was a problem hiding this comment.
Does the Inverter allow you to set 250A? As the docs only mention 100A
There was a problem hiding this comment.
My pull request was intended for X3, but does my pull request apply to X1?
From Solax Modbus spec (V3.24):
There was a problem hiding this comment.
I was actually looking at 0xD7, where it only mentions 32-100A. It's common for there to be a difference within the docs...
I would keep it at 10-250, people can then set it to what suits.
Or we could have an X1 0x71 with 10-100 and an X3 0x71 with 10-250?
| @@ -2842,6 +2854,13 @@ def value_function_battery_voltage_cell_difference(initval, descr, datadict): | |||
| allowedtypes = HYBRID | GEN4 | GEN5, | |||
| internal = True, | |||
| ), | |||
| SolaXModbusSensorEntityDescription( | |||
| name = "Main Breaker Current Limit", | |||
There was a problem hiding this comment.
name =
Isn't actually required on Internal entities, only the key is required.
There was a problem hiding this comment.
Do you want me to remove it then so that it is consistent with other Internal entities?
There was a problem hiding this comment.
OK, will do. :)
Should I also add X1 and X3 in the list of allowedtypes?
mikael-andersson
force-pushed
the
main
branch
from
de91d33 to
5184e05
Compare
mikael-andersson
force-pushed
the
main
branch
from
5184e05 to
fef7079
Compare
NB Tested only on G4, can someone please look into G5?